From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Thomas Graf <tgraf@redhat.com>, Jesse Gross <jesse@nicira.com>,
<pshelar@nicira.com>, <dev@openvswitch.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Eric Dumazet <edumazet@google.com>,
Daniel Borkmann <dborkman@redhat.com>,
Tom Herbert <therbert@google.com>,
Jason Wang <jasowang@redhat.com>, Florian Westphal <fw@strlen.de>,
Joe Perches <joe@perches.com>, Simon Horman <horms@verge.net.au>,
Jiri Pirko <jiri@resnulli.us>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paul Durrant <Paul.Durrant@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Miklos Szeredi <mszeredi@suse.cz>,
<netfilter-devel@vger.kernel.org>, <netfilter@vger.kernel.org>,
<coreteam@netfilter.org>, <xen-devel@lists.xenproject.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>
Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 19 Mar 2014 21:07:08 +0000 [thread overview]
Message-ID: <532A06FC.5000001@citrix.com> (raw)
In-Reply-To: <532A026E.5070609@redhat.com>
On 19/03/14 20:47, Thomas Graf wrote:
> On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
>> skb_zerocopy can copy elements of the frags array between skbs, but it
>> doesn't
>> orphan them. Also, it doesn't handle errors, so this patch takes care
>> of that
>> as well.
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
>> ---
>
>> + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
>> + skb_tx_error(to);
>> + return -ENOMEM;
>> }
>
> I think you should move this down to right before we iterate over the
> frags.
I agree, I was mislead by that __skb_fill_page_desc, but now I see it is
actually the head buffer of the source, not a frag from there. And in
case of a failure in skb_copy_bits we can spare an orphan_frag.
Zoli
next prev parent reply other threads:[~2014-03-19 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 20:38 Zoltan Kiss
2014-03-19 20:47 ` Thomas Graf
2014-03-19 21:07 ` Zoltan Kiss [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 21:17 Zoltan Kiss
2014-03-19 20:24 ` David Miller
2014-03-19 20:39 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A06FC.5000001@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=jasowang@redhat.com \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
--cc=tgraf@redhat.com \
--cc=therbert@google.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome