From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: "Reddy, Sreekanth" <Sreekanth.Reddy@lsi.com>,
jejb@kernel.org, JBottomley@Parallels.com
Cc: linux-scsi@vger.kernel.org, Sathya.Prakash@lsi.com,
Nagalakshmi.Nandigama@lsi.com, linux-kernel@vger.kernel.org,
sreekanthreddy0547@gmail.com
Subject: Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable_eedp to Disable EEDP Support
Date: Thu, 20 Mar 2014 18:28:32 +0100 [thread overview]
Message-ID: <532B2540.8050601@fastmail.fm> (raw)
In-Reply-To: <20140314153622.GA7947@lsi.com>
> u8 scsi_io_cb_idx;
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 7f0af4f..d502728 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -127,6 +127,11 @@ static int disable_discovery = -1;
> module_param(disable_discovery, int, 0);
> MODULE_PARM_DESC(disable_discovery, " disable discovery ");
>
> +/* Enable or disable EEDP support */
> +static int disable_eedp;
> +module_param(disable_eedp, uint, 0);
> +MODULE_PARM_DESC(disable_eedp, " disable EEDP support: (default=0)");
Wouldn't it make sense to exlain what EEDP means? Something like
MODULE_PARM_DESC(disable_eedp,
" disable end-to-end data protection support (DIF): "
"default=0)");
prev parent reply other threads:[~2014-03-20 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 15:36 Reddy, Sreekanth
2014-03-14 20:37 ` Martin K. Petersen
2014-03-19 22:21 ` James Bottomley
2014-03-20 13:25 ` Reddy, Sreekanth
2014-03-20 17:28 ` Bernd Schubert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B2540.8050601@fastmail.fm \
--to=bernd.schubert@fastmail.fm \
--cc=JBottomley@Parallels.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sathya.Prakash@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanthreddy0547@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome