From: Behan Webster <behanw@converseincode.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
dwmw2@infradead.org, pageexec@freemail.hu,
Mark Charlebois <charlebm@gmail.com>
Subject: Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable
Date: Sat, 22 Mar 2014 08:45:49 -0700 [thread overview]
Message-ID: <532DB02D.4030602@converseincode.com> (raw)
In-Reply-To: <201403221101.16961.arnd@arndb.de>
On 03/22/14 03:01, Arnd Bergmann wrote:
> On Saturday 22 March 2014, behanw@converseincode.com wrote:
>> diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h
>> index d8d4c89..4c41bb8 100644
>> --- a/include/asm-generic/cmpxchg-local.h
>> +++ b/include/asm-generic/cmpxchg-local.h
>> @@ -41,6 +41,7 @@ static inline unsigned long __cmpxchg_local_generic(volatile void *ptr,
>> break;
>> default:
>> wrong_size_cmpxchg(ptr);
>> + prev = 0;
>> }
>> raw_local_irq_restore(flags);
>> return prev;
>
> How about using __unreachable() instead to annotate the fact that you won't
> get here?
Yours is a _much_ better idea. Will fix.
Thanks,
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2014-03-22 15:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 6:38 behanw
2014-03-22 10:01 ` Arnd Bergmann
2014-03-22 15:45 ` Behan Webster [this message]
2014-03-22 15:48 ` [PATCH v2] " behanw
2014-03-22 16:21 ` Sam Ravnborg
2014-03-22 16:31 ` Behan Webster
2014-03-22 16:35 ` [PATCH v3] " behanw
2014-03-22 16:29 ` [PATCH v2] " James Bottomley
2014-03-22 16:37 ` Behan Webster
2014-03-22 16:42 ` James Bottomley
2014-03-23 6:32 ` Behan Webster
2014-03-24 5:53 ` [PATCH v4] " behanw
2014-03-25 17:16 ` Arnd Bergmann
2014-03-24 9:46 ` David Howells
2014-03-31 20:52 ` [PATCH] " H. Peter Anvin
2014-03-31 22:10 ` Behan Webster
2014-03-31 22:11 ` H. Peter Anvin
2014-03-31 22:16 ` Behan Webster
2014-03-31 22:19 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532DB02D.4030602@converseincode.com \
--to=behanw@converseincode.com \
--cc=arnd@arndb.de \
--cc=charlebm@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pageexec@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome