From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbaCVUpx (ORCPT ); Sat, 22 Mar 2014 16:45:53 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:50408 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbaCVUpw (ORCPT ); Sat, 22 Mar 2014 16:45:52 -0400 Message-ID: <532E0486.3010702@cogentembedded.com> Date: Sun, 23 Mar 2014 00:45:42 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Kees Cook , Paul Gortmaker CC: Ralf Baechle , Sanjay Lal , John Crispin , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: export icache_flush_range References: <20140322154720.GA23863@www.outflux.net> In-Reply-To: <20140322154720.GA23863@www.outflux.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/22/2014 06:47 PM, Kees Cook wrote: > The lkdtm module performs tests against executable memory ranges, so > it needs to flush the icache for proper behaviors. Other architectures > already export this, so do the same for MIPS. > Signed-off-by: Kees Cook > --- > This is currently untested! I'm building a MIPS cross-compiler now... > If someone can validate this fixes the build when lkdtm is a module, > that would be appreciated. :) > --- > arch/mips/mm/cache.c | 1 + > 1 file changed, 1 insertion(+) > diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c > index fde7e56d13fe..b3f1df13d9f6 100644 > --- a/arch/mips/mm/cache.c > +++ b/arch/mips/mm/cache.c > @@ -38,6 +38,7 @@ void (*__flush_kernel_vmap_range)(unsigned long vaddr, int size); > void (*__invalidate_kernel_vmap_range)(unsigned long vaddr, int size); > > EXPORT_SYMBOL_GPL(__flush_kernel_vmap_range); > +EXPORT_SYMBOL_GPL(flush_icache_range); Have you run this thru scripts/checkpatch.pl? It would have told you that an export should immediately follow the corresponding function body, AFAIK. WBR, Sergei