Re: [PATCH v3] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA

[Bart Van Assche <bvanassche@acm.org>]

On 2/10/26 8:51 AM, Igor Pylypiv wrote:
> On Tue, Feb 10, 2026 at 12:38:51PM +0100, Hannes Reinecke wrote:
>> On 2/9/26 22:21, Igor Pylypiv wrote:
>>> +	if (sn_size < len + 1)
>>> +		return -EINVAL;
>>> +
>>> +	memcpy(sn, d, len);
>>
>> 'len' might well be '0' after 'strim()', please check
>> before calling 'memcpy'.
> 
> It looks like calling a memcpy() with zero length is a no-op. Is checking
> for len > 0 really necessary in this case?

It seems to me that the Linux kernel memcpy() implementation handles len 
== 0 fine. From lib/string.c:

void *memcpy(void *dest, const void *src, size_t count)
{
	char *tmp = dest;
	const char *s = src;

	while (count--)
		*tmp++ = *s++;
	return dest;
}
EXPORT_SYMBOL(memcpy);

Bart.