From: Waiman Long <llong@redhat.com>
To: Gregory Price <gourry@gourry.net>, linux-mm@kvack.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com,
akpm@linux-foundation.org
Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim
Date: Sat, 19 Apr 2025 20:31:41 -0400 [thread overview]
Message-ID: <532fe761-4907-4f4b-b98d-566453301399@redhat.com> (raw)
In-Reply-To: <20250419053824.1601470-3-gourry@gourry.net>
On 4/19/25 1:38 AM, Gregory Price wrote:
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index 893a4c340d48..c64b4a174456 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -171,6 +171,7 @@ static inline void set_mems_allowed(nodemask_t nodemask)
> task_unlock(current);
> }
>
> +extern bool cpuset_node_allowed(struct cgroup *cgroup, int nid);
> #else /* !CONFIG_CPUSETS */
>
> static inline bool cpusets_enabled(void) { return false; }
> @@ -282,6 +283,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq)
> return false;
> }
>
> +static inline bool cpuset_node_allowed(struct cgroup *cgroup, int nid)
> +{
> + return false;
> +}
> #endif /* !CONFIG_CPUSETS */
I suppose we should return true in the !CONFIG_CPUSETS case.
Other than that, the patch looks good to me.
Cheers,
Longman
next prev parent reply other threads:[~2025-04-20 0:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 5:38 [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Gregory Price
2025-04-19 5:38 ` [PATCH v3 1/2] cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed Gregory Price
2025-04-19 18:37 ` Shakeel Butt
2025-04-19 5:38 ` [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Gregory Price
2025-04-19 18:48 ` Shakeel Butt
2025-04-20 0:14 ` Waiman Long
2025-04-21 17:39 ` Shakeel Butt
2025-04-21 22:59 ` Gregory Price
2025-04-21 23:15 ` Shakeel Butt
2025-04-21 23:58 ` Gregory Price
2025-04-22 0:10 ` Shakeel Butt
2025-04-22 0:39 ` Waiman Long
2025-04-22 0:35 ` Waiman Long
2025-04-22 1:00 ` Gregory Price
2025-04-22 0:10 ` Waiman Long
2025-04-22 0:16 ` Shakeel Butt
2025-04-20 0:31 ` Waiman Long [this message]
2025-04-20 23:59 ` Gregory Price
2025-04-21 23:37 ` Shakeel Butt
2025-04-19 17:21 ` [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532fe761-4907-4f4b-b98d-566453301399@redhat.com \
--to=llong@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®