From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754265AbcE3IRA (ORCPT ); Mon, 30 May 2016 04:17:00 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:61701 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754075AbcE3IQ6 convert rfc822-to-8bit (ORCPT ); Mon, 30 May 2016 04:16:58 -0400 From: Arnd Bergmann To: Nava kishore Manne Cc: Rob Herring , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , Michal Simek , Soren Brinkmann , "balbi@ti.com" , "gregkh@linuxfoundation.org" , Hyun Kwon , Radhey Shyam Pandey , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] Axi-usb: Add support for 64-bit addressing. Date: Mon, 30 May 2016 10:16:43 +0200 Message-ID: <5333252.Un7tdhWc5Q@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1464067268-35299-1-git-send-email-navam@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:SJCrGj4w33K0ZkpG98GlC1+vKlwXcesyCnWyCxFnSsuriZIApyO QoyF11/y5asKJQkU6v2GI/drGeH6dqPdTrmJ10qNiehVeJpmcEFfA+4bsbUWWKUwJ+5KbfS +P26jpGF4Nykcco9bw/kJtvMnNP85J4wPvk9VB/GT1iTpXPHcRvRoncPN0cLXNvCsO50+M1 np8mGrOh+a9yQT6/W5Qfw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GziZ+/nGQSY=:CfU152gy3tyumSLY4H4w2F TD9Zo4raLWZWZnT/esc0aVyC1YHmsPAlcEhe55uppc2dtWhfe6GWJSXfQAn2loP1VbvglonVn pikrWINcen7GgZHxTkiaroeJeUa+kNA/OCjDmU8z2HMatM7sTGFJKEo0gGrZaL8n2HGv6v22h UMPQNiWp/+sTfHfyKpTZ7zYxXg+tr7zqnRaw8AWvZoTUsGck6tZOAttXZAKm765p/uhqq+LLJ NSBXc8xyI3bWIiIGUydMqAskhdMV7CatqI0a91SqnLEjig/zlsaBUQFFqowKHVbuej3bJOdIp jYpEWddWbPWWS9rtDCvqSkUHO0sWWNqWODv+DtaX9mHwJFByxEWgQ6aYjLNCH4650D6MH5vQf fmoYikBTIg7z79s7CFrWSRVzSCBF7OM3gIWOQVJsnREjev7FvXk0nT+9jyQGztxjnuYJgyjxM KbUg5jnYsB+yyzyFD6/RznUXZ+ln0j3jrGBVdvaXSliDHTRTCGbTqR6C83qmLggunj7+3wymM auVCnKMuuO+3zviXy2nJoQcOWZgBbIASS4mSME4xFJlk3MBVOkwhh+NMCOObv+XU+Bwj5TiPO kZ0Y5Kg+OMbn7z9l2rlR7v/PgRKUQwf3357g/5IWswN+3S3yB6ob4S/iDunslsOtdlIyxUvWT QiZi7jXffkFrFo4rJKXIvtNg91AIE/0iFqYTO8ePbIMsVpTISqu1k1BFBYA4PM7zPoipMvkQO p9MNkaBMsSzDbMhcSEUKT1UoP6SzaOle/oNOEw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 30, 2016 5:46:21 AM CEST Nava kishore Manne wrote: > > > The Axi-usb 5.00 IP is a FPGA based one. This IP needs to support two H/w designs one with 32 bit DMA addressing another one is 64 bit DMA addressing. > And also in the software point for view we don’t have any register to figure out whether it is supporting 32 bit DMA addressing or 64 bit DMA addressing. > To support both the designs I kept addrwidth property in the dt. I think here addrwidth property is make sense to differentiate the h/w configurations. > If you want me to changes it to boolean please let me know I will fix it in the next version. I think boolean would be more logical here, since what is configurable here is not how many bits are supported, but whether the XUSB_DMA_DSAR_ADDR register is present or not. Arnd