From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756385AbdJLNQh (ORCPT ); Thu, 12 Oct 2017 09:16:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42794 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550AbdJLNQg (ORCPT ); Thu, 12 Oct 2017 09:16:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4E38C601A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=awallis@codeaurora.org Subject: Re: [PATCH v3 0/5] Switch arm64 over to qrwlock To: Will Deacon , linux-kernel@vger.kernel.org Cc: peterz@infradead.org, boqun.feng@gmail.com, Jeremy.Linton@arm.com, mingo@redhat.com, longman@redhat.com, paulmck@linux.vnet.ibm.com, linux-arm-kernel@lists.infradead.org References: <1507810851-306-1-git-send-email-will.deacon@arm.com> From: Adam Wallis Message-ID: <53399b22-8062-aa06-8569-e3fb0ae70ff0@codeaurora.org> Date: Thu, 12 Oct 2017 09:16:33 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507810851-306-1-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 8:20 AM, Will Deacon wrote: > Hello, > > This is version three of the patches previously posted here: > > v1: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534666.html > v2: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534981.html > > Changes since v2 include: > > * Drop unused cnt argument > * Fix typo in UNLOCK Kconfig inlining options > * Added Tested-by tags > > Thanks to all of those who provided review and testing feedback! > > Will > > --->8 > > Will Deacon (5): > kernel/locking: Use struct qrwlock instead of struct __qrwlock > locking/atomic: Add atomic_cond_read_acquire > kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock > arm64: locking: Move rwlock implementation over to qrwlocks > kernel/locking: Prevent slowpath writers getting held up by fastpath > > arch/arm64/Kconfig | 17 ++++ > arch/arm64/include/asm/Kbuild | 1 + > arch/arm64/include/asm/spinlock.h | 164 +------------------------------- > arch/arm64/include/asm/spinlock_types.h | 6 +- > include/asm-generic/atomic-long.h | 3 + > include/asm-generic/qrwlock.h | 37 ++----- > include/asm-generic/qrwlock_types.h | 15 ++- > include/linux/atomic.h | 4 + > kernel/locking/qrwlock.c | 86 +++-------------- > 9 files changed, 61 insertions(+), 272 deletions(-) > Will, I see the same performance improvements that I was getting in v2 of the patch. I will continue to run these patches on multiple systems over the next few weeks, months for stability/functionality testing as well. Tested-by: Adam Wallis -- Adam Wallis Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.