From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>, <corbet@lwn.net>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v4 0/4] x86/resctrl: Non-contiguous bitmasks in Intel CAT
Date: Fri, 6 Oct 2023 10:53:52 -0700 [thread overview]
Message-ID: <533ccc1b-7566-444e-8549-184fd272f666@intel.com> (raw)
In-Reply-To: <cover.1696493034.git.maciej.wieczor-retman@intel.com>
Hi Maciej,
On 10/5/2023 1:14 AM, Maciej Wieczor-Retman wrote:
> Until recently Intel CPUs didn't support using non-contiguous 1s
> in Cache Allocation Technology (CAT). Writing a bitmask with
> non-contiguous 1s to the resctrl schemata file would fail.
>
> Intel CPUs that support non-contiguous 1s can be identified through a
> CPUID leaf mentioned in the "Intel® 64 and IA-32 Architectures
> Software Developer’s Manual" document available at:
> https://www.intel.com/content/www/us/en/developer/articles/technical/intel-sdm.html
>
> Add kernel support for detecting if non-contiguous 1s in Cache
> Allocation Technology (CAT) are supported by the hardware. Also add a
> new resctrl FS file to output this information to the userspace.
> Keep the hardcoded value for Haswell CPUs only since they do not have
> CPUID enumeration support for Cache allocation.
>
> Since the selftests/resctrl files are going through many rewrites and
> cleanups the appropriate selftest is still a work in progress. For
> basic selftesting capabilities use the bash script attached below this
> paragraph. It checks whether various bitmasks written into resctrl FS
> generate output consistent with reported feature support.
This work conflicts with Babu's series [1] that is also ready for inclusion.
We could wait for outcome of next level review to determine who will need
to rebase. It may help to provide a snippet of the conflict resolution
in anticipation of Babu's series being merged first (I will propose exactly
the same to Babu for the scenario of this work merged first).
Reinette
[1] https://lore.kernel.org/lkml/20231003235430.1231238-1-babu.moger@amd.com/
next prev parent reply other threads:[~2023-10-06 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 8:14 Maciej Wieczor-Retman
2023-10-05 8:15 ` [PATCH v4 1/4] x86/resctrl: Rename arch_has_sparse_bitmaps Maciej Wieczor-Retman
2023-10-06 14:21 ` Moger, Babu
2023-10-05 8:15 ` [PATCH v4 2/4] x86/resctrl: Enable non-contiguous CBMs in Intel CAT Maciej Wieczor-Retman
2023-10-06 14:24 ` Moger, Babu
2023-10-05 8:15 ` [PATCH v4 3/4] x86/resctrl: Add sparse_masks file in info Maciej Wieczor-Retman
2023-10-06 14:30 ` Moger, Babu
2023-10-05 8:15 ` [PATCH v4 4/4] Documentation/x86: Document resctrl's new sparse_masks Maciej Wieczor-Retman
2023-10-06 20:42 ` Moger, Babu
2023-10-09 6:35 ` Maciej Wieczór-Retman
2023-10-06 17:53 ` Reinette Chatre [this message]
2023-10-09 6:44 ` [PATCH v4 0/4] x86/resctrl: Non-contiguous bitmasks in Intel CAT Maciej Wieczór-Retman
2023-10-09 12:40 ` Borislav Petkov
2023-10-09 15:32 ` Reinette Chatre
2023-10-09 16:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533ccc1b-7566-444e-8549-184fd272f666@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®