From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D2F435958 for ; Wed, 24 Dec 2025 11:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766576114; cv=none; b=CN2QLBt+M6wqNnGWETApf51Ve5GNb6Vu3Fe8p0guTMvofVFy6JJ2BxXWD+fPI4ouQkGTd8yQiwo44Vaw7SlCEI4E1g9Y0zWGBXzBIw6dTbiqxYV3Y0Yz0lOAPG3Da+GkX+1uCQ8ZC9F+5j8ep1FuTl4lN8B/NCsqokA9FjCGSBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766576114; c=relaxed/simple; bh=uKDGNuh1IQt88aA2tRjBcRWwQ7BLhlXXPWTvF8MdYpY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YXFuLW5b3anoLGiORws+mM01olFhE1lbuPTNpyBClomMahZUF8zLXuKeXdyKNny2EDTV3duLewn6mbpx45dh4bS+UoaSxf+1GtPhNKd4YjTfMmhxJitfcQIHXMp9TIldDuAU3IKvwdKFA0A2Z9e26XtKiVUyTI4KRrbFc8M9gyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=f+ipvznN; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="f+ipvznN" Message-ID: <533d2818-b7ed-4bdf-a69b-5ca2678ef193@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766576109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4r+rkBsBIRRgeO/AD5wwWFdV4DArdg4UZWAqYivFNs=; b=f+ipvznNzx2BGJa7BQHWc6B7JD9Qq54vNmjmGvPaEXx/ICCLDP4vErBdNrqGf7ARGH3RE7 szdz60O6/eYKyLCGaHaslJgLXXnOtUHDaXcDX/W2Dh4DP9Te/QAXc056UXzTC3n9DjcfTy s42844qNlAcL6DQ2EzUKH4C9nvA0Ur8= Date: Wed, 24 Dec 2025 19:34:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH V2 1/5] mm/khugepaged: remove unnecessary goto 'skip' label To: Shivank Garg Cc: Zi Yan , Lorenzo Stoakes , Baolin Wang , Andrew Morton , "Liam R . Howlett" , Nico Pache , Ryan Roberts , David Hildenbrand , Dev Jain , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20251224111351.41042-4-shivankg@amd.com> <20251224111351.41042-6-shivankg@amd.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20251224111351.41042-6-shivankg@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/12/24 19:13, Shivank Garg wrote: > Replace goto skip with actual logic for better code readability. > > No functional change. > > Reviewed-by: Liam R. Howlett > Reviewed-by: Zi Yan > Acked-by: David Hildenbrand (Red Hat) > Signed-off-by: Shivank Garg > --- LGTM. Reviewed-by: Lance Yang > mm/khugepaged.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 6c8c35d3e0c9..107146f012b1 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, > break; > } > if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORDER)) { > -skip: > progress++; > continue; > } > hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE); > hend = round_down(vma->vm_end, HPAGE_PMD_SIZE); > - if (khugepaged_scan.address > hend) > - goto skip; > + if (khugepaged_scan.address > hend) { > + progress++; > + continue; > + } > if (khugepaged_scan.address < hstart) > khugepaged_scan.address = hstart; > VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK);