From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758760AbdLROg3 (ORCPT ); Mon, 18 Dec 2017 09:36:29 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34130 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758333AbdLROg1 (ORCPT ); Mon, 18 Dec 2017 09:36:27 -0500 Subject: Re: jsm_tty: Deletion of a null pointer check in two functions? To: SF Markus Elfring Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Joe Perches , Jiri Slaby , LKML , kernel-janitors@vger.kernel.org References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net> <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com> <1511977896.19952.69.camel@perches.com> <20171129180528.GA24705@kroah.com> <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net> <8ae240fa-7f77-8f4c-225c-853cdda73a67@linux.vnet.ibm.com> <817fcf72-cd9d-bf5b-ce83-ce2844e3e901@users.sourceforge.net> From: "Guilherme G. Piccoli" Date: Mon, 18 Dec 2017 12:36:15 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <817fcf72-cd9d-bf5b-ce83-ce2844e3e901@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121814-0008-0000-0000-000002B13D27 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008222; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00962039; UDB=6.00486596; IPR=6.00742034; BA=6.00005750; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018605; XFM=3.00000015; UTC=2017-12-18 14:36:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121814-0009-0000-0000-000037A09530 Message-Id: <533d608d-c502-824f-9c79-880e387f4d09@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-18_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712180194 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/2017 04:27 AM, SF Markus Elfring wrote: >> Thanks for the fix. > > Thanks for your positive feedback. > > >> I was on vacation - but now seeing all the analysis made here, > > I assume that special communication settings could trigger > corresponding consequences for the discussed source code adjustment. > > >> if "ch" can't be NULL then please go ahead and remove the check =) > > Would you dare to convert this request into a concrete patch? For me, it's OK if you send the patch or I can do it myself. It's a minor patch...but it's correct the way I see it. So, what do you prefer? Send it yourself, or want me to send it with your sign-off too? (since was your idea). Thanks, Guilherme > > Regards, > Markus >