From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965099AbcJQPtk (ORCPT ); Mon, 17 Oct 2016 11:49:40 -0400 Received: from mail-eopbgr50137.outbound.protection.outlook.com ([40.107.5.137]:45472 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935076AbcJQPsz (ORCPT ); Mon, 17 Oct 2016 11:48:55 -0400 X-Greylist: delayed 24617 seconds by postgrey-1.27 at vger.kernel.org; Mon, 17 Oct 2016 11:48:51 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v2] kasan: support panic_on_warn To: Dmitry Vyukov , , References: <1476694764-31986-1-git-send-email-dvyukov@google.com> CC: , , From: Andrey Ryabinin Message-ID: <53400e91-cf51-1bff-c5e4-0a02cd9c2290@virtuozzo.com> Date: Mon, 17 Oct 2016 12:14:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476694764-31986-1-git-send-email-dvyukov@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM5PR0501CA0022.eurprd05.prod.outlook.com (10.164.187.32) To VI1PR0802MB2558.eurprd08.prod.outlook.com (10.172.255.136) X-MS-Office365-Filtering-Correlation-Id: 688ea9d5-2baf-4390-fe3b-08d3f66df562 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;2:oEXgat8x7+Bg5RNlMJ9RNU00UCBvqvdDVpMgGFL1SmCChlLCc5/Tk4b6b2YmUxVSR30ZVQCyFFUXE78bENAR2HSBUWHB4RhyCg4lRZRj0xtwfGKW8yKuIgJeH16nCheYaaw4xzIhL7+cy2nsj9ZsWFY3q/RzmeYYoe7+LXsT7lVMUM+Jzyl/A8trVrsInAHVpFZIQy1E0NGRKP4kkfB9Yg==;3:fbaB4IBnPPF215lKXsI3YBX38rPGKH8DZ2ZdkgEzaJKLllKURJd8G/4wO+jQjVDL+G6v4ur5DH3vW9odAH/S18zD3++Loyu/Ugataxo/+zK6MgNJ8BgKZsW36J71OA3PuL5BytjjpgmjvQDWTlqd6w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;25:+cmy7XpPNGoQc6G+IfENWk9a2wN1aobIQ/eEOYV1XzB4/Y1dBfdqM1LZq4W6X0W93PrtJrVHLgVNsxEKxxUlEp2Dsq+0XDcGTa3nUGTA6kOoMRbcHiMloeYtruyz1yPnByfwxzTv9CLTKT+nodJeJnO0icwIoTti1DvIEIDDXv4Hd8VPKh/+VR9eAoC43Y5EHo/4Z8+0aEhFH9vFx5iM+Omb7FIrJbeVpLoA0sley7QlgCtDJwEuKQT/g8B2i6EscjBnhTvI7DLoLHAuF92PPR3/3QanFukSJcHsEube1nWtWCJGspaMNKyYs3fGUgQ9tgmTFA/BS2dhoEEP1KDhSbo8c/e49KEaSP1kp3rhQM6DQLQl+ZYUjpXr/5bQNq65HUxwUkOst1RbEvzkedJP1NEW+9kdZLzA/P5rpt3Z4ltY3b8m5u46ThRHmGqnrakroBlcIy4g9vvurfcU4+Qk6K4oRp/AYjb+WVsaSRiZxbLwt3jeZ8WBiEm2izPvEQe2UyVVDa1p9jp7EbKKz4vw/CE/TxTfmtHXWpedAruNVu4tgpeUhW9ImGUlQ2lT1uhWYqeNqpmSNGRW1aYsDWP7rHKIetGkf6E6l57K9Tnjg2NO3z/SYTWfWWUmApELD1QxkiAVzg6u+gKWW7qbEuVzSq1B8Yu3qph7pXiNWOHJReVfmOe6Fq0fTCXgcNYlBJNH9SkdWHcBX/hp3x80/qrIa0vtt7hnfh43SWwM6r+C4uCGO86PsInJCOGyFSYT1N5N X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;31:r/ZNhieFkcrj6kXLXt6HleOdFyEi1d/cWdbe8p+P5W/GdVmR3P9gKK2+LHyvqGFxuzO2YtRf/3xibnj78I6g9B+CPWOuoNzsZjHxxekWP2inNXKoiphiNrqBVVjFVES1CCLNp6aAx7lAAhT6PpY1IXrO6cCUjbQhQ5pYxi8B56rzWka8W07WolEcEaj5Y5rkeKpxJNlTyObB2hjATVcksocFxwXJISC+0juoljWH5LB86DJwl3XJbW7v5HYpPmQtuO1ljr49diwAFYbeMFf5aQ==;4:skZwXAOtHq7zUfusS+UAYG73G3Y3rpMYL3ydZ8GOziHu231labyF73RhyX6kB5XF6XSxl5VwEgbuo/koe9WP+NPfTSZfBzrGpcAOAkfUzfmpDbpQSXqp7Xt8CA6wYWmYQlqzNwkGEWuDUeWR5hMJUyixr9/aDTXbqJ2FTZ3K9dSXtba2iZFb9Nu7AxEqrRxdCFqUI6FO4i5MRGqkqTAzSvY06oKA3bNLOqzRP/jntBZsrF9buyhb0FdvEMA69XKVRIGqkGb+1dUrMUqQXK+LRs8sGXT/oUpNK7eyO9wlZ7omPSly6y51aK09ilA1aWn5ibTQnVzIHpwbad45pILvacbx/AxDR3WuI/Tjwf3Ov18fFhErUyT2FIB4t9FYN12joXWdCoc948Cj6DK9OOepnFBymrYDQTof2NbARMhqd9aGwJ3FJqErTCLMVPr5qE8w6HQUWZWk3JTRvtdGEo7KLUodl7EDdoCG22FZyDkFGFoZBF0WwKLVfuHi8y+2pJIir/EkCKJk5B9FXnDKOqozWgODQXNn/9AbBR8C/IpRXB4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(215639381216008)(9452136761055)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6043046)(6042046);SRVR:VI1PR0802MB2558;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2558; X-Forefront-PRVS: 0098BA6C6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(199003)(377454003)(189002)(92566002)(66066001)(101416001)(76176999)(54356999)(50986999)(105586002)(65806001)(65956001)(77096005)(47776003)(19580395003)(64126003)(36756003)(31696002)(2950100002)(2201001)(31686004)(23746002)(42186005)(83506001)(68736007)(86362001)(19580405001)(65826007)(33646002)(5660300001)(106356001)(50466002)(81166006)(81156014)(4326007)(97736004)(189998001)(5001770100001)(4001350100001)(8676002)(2906002)(230700001)(7736002)(6116002)(7846002)(305945005)(3846002)(586003);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0802MB2558;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0802MB2558;23:JHrqkV0LzXDMZ4cjsCLqGWfBOu4ttdRYvQm?= =?Windows-1252?Q?tes7lJfzlmvR1cWEJWrnnOoIWCjy6eu6X/w+i4s8dgBzCNmSNBu5Mzuw?= =?Windows-1252?Q?WSLxXkN1tH90CtAYrjioo4kmEtwFzGVLGfyK1VF/2DiAM/N7YCaGHJK1?= =?Windows-1252?Q?+VEw6avmDRZL+Hbmu/8rX2hSIV9Awf8LYvV09WAahSY9eseIDl4GRA7s?= =?Windows-1252?Q?YOO+4nYLsXwifHNh17CWz2ce9xs3ThtkcGdAfFrvcveIT2elE6tb8KhB?= =?Windows-1252?Q?CdP/gI+Z6lJ8W74xfI1yiHAUJadsvvb0SHC3BhJ7dUg8mGtT/ptL2oDp?= =?Windows-1252?Q?X0+Bb64IHHcZnSHJtUikD09FPb2onmqGd5bVmfA+1B0fM7WMlezFAiy0?= =?Windows-1252?Q?mFYJ6KEznyPb6Zj0TBRZFNlN1MbgMgBD3ZkjzyuLsVjPv3kokIUL0c/n?= =?Windows-1252?Q?NxQDNIFVg8bDpe3H8tfqIJMcl8oc32gQxOtw7NDuVoNZPA7YbcdJ+ioo?= =?Windows-1252?Q?rPqkZLwQ2+jXXhukXNEv/iSwMs3Z8INWDG9CtnG6/dFLIN0S4FF0zfn+?= =?Windows-1252?Q?58N3Y+Bs2vzUZ75S7/sGP1W2746VQXTJy018I9tVhjQhvw0Ccrlv8OQV?= =?Windows-1252?Q?O9P1aCj/nLyH/PqV+IXA8r03u3DfaVYGSi7AJrL7WM4iqJEBzjA+aZWC?= =?Windows-1252?Q?+qN1g5OgZCc+w8CTnbgKJd4wAAUx9P2IBIFM77gxHHt4CzcFYw3n+TxO?= =?Windows-1252?Q?IGawVFdHWkV/kD37ETOtT/K1SYQ0vi2poKe7AwNUdSNOZSu5dGndR68v?= =?Windows-1252?Q?VNd4eV8Thsmc62EB+tbWlthwEuHfE86qd9ySr3iCy7/fpCDlaEp1NssM?= =?Windows-1252?Q?iMmC3KAcVBixQdEXDk/6PiKnBx5lGchmuTObxEbkWY5VF9C23vjHzkyl?= =?Windows-1252?Q?OsxStyEi29iGTgI3C4pL4UyAUvV/7Xr2nQtjDX0LoW0724VPWnFXvjlT?= =?Windows-1252?Q?nvgYKefOGqzNFgP9exxDR2kNC//il1W/iEKKj82HiXv7zCiktyRzBT7w?= =?Windows-1252?Q?zbuolTLc0dV+JGJCpFtTJgUEZgot6Vi6cAuc3bHh6zSpb+ox3ZoRQXLL?= =?Windows-1252?Q?ODX9dxAAeGlslO8ixyLR35cpoO0rs294AL+oPvMgzPFcz5RZLxHpibO+?= =?Windows-1252?Q?ft6QLOYU14HmFTXyCoO++mdG1NpQSfpLbtRbdNc+vccdRTe71Bb+ie10?= =?Windows-1252?Q?HHGb9PB81pmzeoEpymBZ8Oo4HtujTU56kWWpHlAhU6ltemYKkVHrDIgL?= =?Windows-1252?Q?iJkYLx8PGhqGbdkiqiqIW0bN/uBNwfOf7Fiql3vG1D171wXNtv0eEDav?= =?Windows-1252?Q?odRUml6/GAsRULS/wfqBc39EFLQ2C0jBLpCNM1F9W0nH932+G7AVfNMA?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;6:wuoNOQApmWX6yIx4IrgT+Fm/+TZzVqlXoA6zp5QkwzEKIlgJA7+k5f3KveHUPbGSae1PH/Pkbky/2dLQnaR9XCcL6pJg17zG9YYSUJCrozgUOhy1pq+B/HNaekqhTGDW3Uo0qcAWIhbTMPtWLkawzp7NXSK/FPoMOmLg3tLzGNiGV6/3FM9/YWIABA1bO65AUlA1CtfkdIGMXWsF55O2aSIJMAo1FLwC7I7dwEopprhKfVKbT7GW7doAB/Akhs6JPsGQpBGeUCPmZlgoYuqR5AGOOVXtiHmNTtGK/eur3k84Uh915taUwjVpdSCMgb4HKcLFGv5AtQBzIN/X0qG20w==;5:rINedGNhS8aDuVrmchk5nrSz10PwiKTkGB7G5CUo03V0N2Cjn6XTeYydLVaqFSqXoDzn+8FL31ftIO7g7UTWMoqzV4EYooWzSJbO9Bm/imEriQU2vfkX98DlBi6Fvwjz8qPVYM8LygcSv865FmfJkfQhGY/8IMW2iJS8AU6HbmU=;24:pGnNneXgVoWzhjTR1woD9kKBLbjzVYaItbDzWtmtmH6bEMIoPswW5a19dGfJuK4WjntaJhUUpyfKyGFXxdiBt6iYP8hWJ1rnqbkXXfws2zc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2558;7:TQM9TaYIBLPZlX3fQAjDrxBMBdjq95hg4Yuzk9BT8AfY5RmFZRXtZwpsr0f1BAa3aixBwrEET5rDKXUhXp3Usghyy3dsB0Szpg8tNcSE9AxVg9+pbQeEa18VK9gEJKx4ksM0pCccTz9NXw3qxocubHkFyybg1x84uD3Hu+Noan+hr+T5dhkz8HBy8xqXVGjrOXKUcAHk5tsdXIvxKiV1s7JkEdZ/3G1AagC6LDzmrD6jM2McHiFiVsN1ovMDmjN6SX0+40SQW84aE85SFM2Titv9MVyUxLG7Fu9K7P0XYAiCbSzGR+G4aLJyjQIn9T5lkdsQOuxAIk1lI1T0c5uhGAXS8QThqA1ERyJWq+9dvnQ=;20:xFj+GtC8FNh/zUEDBoJ1JQeBm3BSD7XtYcTrURSRwKuOsv1wNPXrME93b0dR8PMLnMHPa2qsGwCD9t3mPElm8QSgH7xKYI9I77nEFyd5edMz4KIrp0OJ1pHalzkG1zby7DXPjkjEp9xQqETKC/H1w/jf3WvstfLvofbsgPyUkxM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 09:14:11.2540 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2016 11:59 AM, Dmitry Vyukov wrote: > If user sets panic_on_warn, he wants kernel to panic if there is > anything barely wrong with the kernel. KASAN-detected errors > are definitely not less benign than an arbitrary kernel WARNING. > > Panic after KASAN errors if panic_on_warn is set. > > We use this for continuous fuzzing where we want kernel to stop > and reboot on any error. > > Signed-off-by: Dmitry Vyukov > Cc: kasan-dev@googlegroups.com > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Andrey Ryabinin > --- > > Changes from v1: > - don't reset panic_on_warn before calling panic() > --- > mm/kasan/report.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 24c1211..0ee8211 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -133,6 +133,8 @@ static void kasan_end_report(unsigned long *flags) > pr_err("==================================================================\n"); > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > spin_unlock_irqrestore(&report_lock, *flags); > + if (panic_on_warn) > + panic("panic_on_warn set ...\n"); > kasan_enable_current(); > } > >