From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3588C433E2 for ; Thu, 17 Sep 2020 09:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75F6B206E6 for ; Thu, 17 Sep 2020 09:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbgIQJas (ORCPT ); Thu, 17 Sep 2020 05:30:48 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:38664 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726200AbgIQJaq (ORCPT ); Thu, 17 Sep 2020 05:30:46 -0400 X-Greylist: delayed 309 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 05:30:46 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave06.hostedemail.com (Postfix) with ESMTP id CF5B2800EEB2 for ; Thu, 17 Sep 2020 09:25:37 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 7514F182CF66A; Thu, 17 Sep 2020 09:25:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: watch69_32046bb27121 X-Filterd-Recvd-Size: 2774 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Thu, 17 Sep 2020 09:25:32 +0000 (UTC) Message-ID: <5341538083077360205d50683ac2f3df22cfa72a.camel@perches.com> Subject: Re: [PATCH 1/2] staging: rtl8188eu: use __func__ in hal directory From: Joe Perches To: Michael Straube , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 17 Sep 2020 02:25:31 -0700 In-Reply-To: <20200917071330.31740-1-straube.linux@gmail.com> References: <20200917071330.31740-1-straube.linux@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-09-17 at 09:13 +0200, Michael Straube wrote: > Use __func__ instead of hardcoded function names to clear > checkpatch warnings. [] > diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c [] > @@ -249,7 +249,7 @@ void odm_CommonInfoSelfUpdate(struct odm_dm_struct *pDM_Odm) > > void odm_CmnInfoInit_Debug(struct odm_dm_struct *pDM_Odm) > { > - ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("odm_CmnInfoInit_Debug==>\n")); > + ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("%s==>\n", __func__)); > ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("SupportPlatform=%d\n", pDM_Odm->SupportPlatform)); > ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("SupportAbility=0x%x\n", pDM_Odm->SupportAbility)); > ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("SupportInterface=%d\n", pDM_Odm->SupportInterface)); These ODM_RT_TRACE macro uses are rather ugly. Perhaps a rename to odm_dbg would be better. So would removing the unnecessary parentheses from the macro uses and fixing the macro definition Maybe using a perl script something like the below: our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/; sub deparenthesize { my ($string) = @_; return "" if (!defined($string)); while ($string =~ /^\s*\(.*\)\s*$/s) { $string =~ s@^\s*\(\s*@@s; $string =~ s@\s*\)\s*$@@s; } return $string; } foreach my $file (@ARGV) { my $FILE; my $count; open($FILE, '<', $file) or die("Can't read $file $!\n"); undef $/; my $text = (<$FILE>); close($FILE); $count = $text =~ s/ODM_RT_TRACE\s*\(\s*([^,]*),\s*ODM_COMP_(\w+)\s*,\s*ODM_DBG_(\w+)\s*,\s*($balanced_parens)\s*\)\s*;/"odm_dbg($1, $2, $3, " . deparenthesize($4) . ");"/ge; if ($count > 0) { open($FILE, '>', $file) or die("Can't write $file $!\n"); print $FILE $text; close($FILE); } }