From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82BE1430B8F for ; Sun, 1 Mar 2026 22:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772405146; cv=none; b=C1nl+U6mwq63R1tWuqgytbOj8CJfJVLKK8vLRl2IR5aIscgB9KAoTrx6D8VLNTYR3titbiKuuQ8tgfatzY5v7fYhwbdVEJ+LmK3M2b1grvgXH/XawmAbsD/+eEg8NqV3kHFgBbDj8SoJgy4ysZ8PlOcWELav4S4o52uBp5U4x5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772405146; c=relaxed/simple; bh=U2dadGwNNyKxbfW0uoKnd7FppZIXE76Gd3rLzoWBH2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nigofdZXGlfbn30nL0Qeyim7DKF5KyJUxU9I5dMP1aNGa5St/sJXWkQ/3koy5XNbqWsOZ5AUEwK6GMDcxv5mkh1H7WfudX8UK9Ic6VCJAYrZ+sEJxMJQKu2bW9CZaes3EjhlXRRlWEGG/4ueB69bCg6SWuAuJtQRFKIIzJhdQ84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=X8zxNwrd; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="X8zxNwrd" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-45f126d47b8so3163425b6e.2 for ; Sun, 01 Mar 2026 14:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772405143; x=1773009943; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xbpVRCXsg6ZLdT2k1ZtnZrOmKeMWW4VR9/roCkWMvqo=; b=X8zxNwrdqEBsZR+plVvDl/rMamLpEYndFj0PcWRzYa2wM7fRlpKcxvzf4FjhkD0+0Y cpSOtFH/5rnv3Hkl3w0maWjq20dGqhmrTWcjiPirPZhasbn69N4lm6Un1g2BuY+akIYl IsP+qkgAzys8TC9i8TKre5d0DSA0MGMNRupFcQYQMFoI4qIzJPUWchkODo7TjOwhAAUV 8c4E6S7T+jTBgFfuxv4CtP6ixxJ6wSm120mxUN2lDgkCnkH0rMJNbI6wXotFZROAJKpX 46z5A78szMx6891kExckBxjoJwxURgYbNDQ+EvwfMCzNE76Iio3waRedwLUF+fEkleTZ 41Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772405143; x=1773009943; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xbpVRCXsg6ZLdT2k1ZtnZrOmKeMWW4VR9/roCkWMvqo=; b=JfgeyO664xOI/cvXIWBEABxnIAaNkC+sviyL+80Wpc/2yDJA2p93kAVcQB/hRNXul+ 3yEKLdhBcwrQ+DZYGo0YYV+RbRvwJ9b5Ek96aeRx4wQzlq83TZ4ryFLZXetxqNY0jlDu TBILJZo0FNRJyC54dLDteTMN0cQ02VdWteE0Q6HRyC/Ex4890QUY4ia6oamyOjQaajz/ gGPCQJois6PdqQF/OdkBePc9kN5rZCey9il31efn/jsIzQVqjco4anrR9WfyMFWfuEhz SNWoib+sFEi886KfMwI0e/gRzyY3NI5FBAU4RX/tH9seeUdn/IW4XfbugbjH7vQgNdv2 bCNA== X-Gm-Message-State: AOJu0YyptUTtwJwywb1bxjwP0Y5HOQxy7qcKE/44jZgaVED6gbzDkh6u L4TkirLJavIjJ9RAjvg8WfOM4xZ4cbPFYdjBZHT9fA+LJOWMKGPZSypGPz3NkmsJSX0= X-Gm-Gg: ATEYQzzCIEkBDJMjC9OelG/EAj+TZmKFKiTM4cymbOcP4pthTnSPnpYJc/nOs/sW/g5 Zm3NfX4BIdI7BGq84VSYY2anUa/AI1OKXRVMH2zCMOEXNyvmBKjunisJOxhBRgeeCKjjV/F2hue oszlwh7BsmDMRqtFuZ3QP5vZf/+su033I23VF843eSl+pUrQObfNHeIrTnq+ne49b5dc4vxHXrc Jv4ZhW1uIYMxRtsthYy7NpbPbdfZsIbgNvbAOIZuLQpqLvPfhFPute0rbxfZ8xQZ8lHCZUfcNwj I9swqMqF1RaccrYBh7F6kCcldYq4pJ/reK8VVghjdmGL3lnCqAgY5ZDZYHXqrm1Qwk+JuaZdmNo vI7cGA5XU8H+/o/eTkp2mEPG/ZIJCJfTV8mRZ4dUYzrgA/dAHOth0cI3BEcDDYQIj0UQ/k+UW3l +9plkGp5VtBZ5lkTL1OLpM+FcTiNk+bAU2gqkE11grIaHGbhwTQNID6K9ztCwWeDN43H3Orh/tH w== X-Received: by 2002:a05:6808:1b11:b0:45a:4189:d2cf with SMTP id 5614622812f47-464be947b0dmr4790015b6e.8.1772405143483; Sun, 01 Mar 2026 14:45:43 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:8b9c:d657:204d:5a5f? ([2600:8803:e7e4:500:8b9c:d657:204d:5a5f]) by smtp.gmail.com with ESMTPSA id 5614622812f47-464bb5e417fsm6298197b6e.16.2026.03.01.14.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 14:45:42 -0800 (PST) Message-ID: <53448364-5d86-43ab-a585-202891eef320@baylibre.com> Date: Sun, 1 Mar 2026 16:45:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [tip: irq/core] genirq: Warn about using IRQF_ONESHOT without a threaded handler To: Sebastian Andrzej Siewior , Bert Karwatzki Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , Thomas Gleixner , Laurent Pinchart References: <20260113120541.YVf2vRA3@linutronix.de> <20260202232741.13380-1-spasswolf@web.de> <20260203083826.1gOzxrwt@linutronix.de> Content-Language: en-US From: David Lechner In-Reply-To: <20260203083826.1gOzxrwt@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/3/26 2:38 AM, Sebastian Andrzej Siewior wrote: > On 2026-02-03 00:27:40 [+0100], Bert Karwatzki wrote: >> >> The warning appears because iio_triggered_buffer_setup_ext() (in >> drivers/iio/buffer/industrialio-triggered-buffer.c) is called with thread = NULL >> during the probe of the iio device and calls iio_alloc_pollfunc() >> (in drivers/iio/industrialio-trigger.c) with thread = NULL and type = IRQF_ONESHOT. >> >> A simple fix could be this: >> >> diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c >> index 9bf75dee7ff8..40eea3a44724 100644 >> --- a/drivers/iio/buffer/industrialio-triggered-buffer.c >> +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c >> @@ -64,7 +64,7 @@ int iio_triggered_buffer_setup_ext(struct iio_dev *indio_dev, >> >> indio_dev->pollfunc = iio_alloc_pollfunc(h, >> thread, >> - IRQF_ONESHOT, >> + thread ? IRQF_ONESHOT : 0, >> indio_dev, >> "%s_consumer%d", >> indio_dev->name, >> >> >> Are there any problems with this? > > Urgh. Haven't seen those. > > Looking at all the users of of *iio_triggered_buffer_setup*() the > primary handler is either NULL or iio_pollfunc_store_time(). > So IRQF_ONESHOST should work all the time. > > Then there is > - drivers/iio/adc/vf610_adc.c > - drivers/iio/common/hid-sensors/hid-sensor-trigger.c I think we also have in the list: - drivers/iio/adc/stm32-dfsdm-adc.c > > They use iio_pollfunc_store_time() as primary and have no secondary. > This would trigger the warning but not having a secondary handler while > returning IRQF_WAKE_THREAD should create a warning of its own. > What did I miss? > >> Bert Karwatzki > > Sebastian >