From: Arnd Bergmann <arnd@arndb.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Thierry Reding <treding@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] of: Add stub for of_get_next_parent()
Date: Wed, 27 Apr 2016 13:13:33 +0200 [thread overview]
Message-ID: <5345757.9RfGSJE06M@wuerfel> (raw)
In-Reply-To: <1461755500-889-1-git-send-email-heikki.krogerus@linux.intel.com>
On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> Fixes a compiler error:
>
> drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
> parent = of_get_next_parent(parent);
> ^
>
> Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Yes, this works. I have submitted an alternative patch to fix the
build error, changing the PHY core to not use any of the OF interfaces
if CONFIG_OF is disabled.
We can also have both.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-04-27 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 11:11 Heikki Krogerus
2016-04-27 11:13 ` Arnd Bergmann [this message]
2016-04-27 15:00 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345757.9RfGSJE06M@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome