From: Markus Elfring <Markus.Elfring@web.de>
To: Li zeming <zeming@nfschina.com>,
linux-block@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>,
Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-zoned: Remove unnecessary ‘0’ values from ret
Date: Tue, 28 May 2024 11:22:23 +0200 [thread overview]
Message-ID: <534687df-c200-4741-ad00-a847e8fb8b12@web.de> (raw)
In-Reply-To: <20240318025525.16439-1-zeming@nfschina.com>
> ret is assigned first, so it does not need to initialize the assignment.
* Would a wording approach (like the following) be a bit nicer?
The variable “ret” will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
* How do you think about to use the summary phrase
“Delete an unnecessary initialisation in blkdev_zone_mgmt()”?
Regards,
Markus
prev parent reply other threads:[~2024-05-28 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 2:55 Li zeming
2024-03-19 3:05 ` Chaitanya Kulkarni
2024-05-28 9:22 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534687df-c200-4741-ad00-a847e8fb8b12@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®