From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E8842FFDCB for ; Wed, 24 Jun 2026 09:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782292533; cv=none; b=sqJmcr+sKwzgY7F/wwpR4hUfC2IFBePdYpBuUJaHRwA82ZMxkAMM4PMf5uAn594NDyklmIHAzauTp+2zdpvIuABR94jgbm4ckS1r67abra/yzS7R95nxYOdBZyJBSOJmDmioGEYV9xv5z5HaW7H4C602ASCQ506pNFTxiAjqIik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782292533; c=relaxed/simple; bh=mVhTV0P6q5eN5Ik+32E53jIoJ54h5EF1gxVvdCrRjWc=; h=From:To:Cc:Subject:Date:Message-ID:References:MIME-Version: Content-Type; b=fwwBufZvxWmSd1NpgeTDkifdfQxZHfJGjkrwDprscK8QtKRbz7xqUieCYmchS9fP8MijGGHQVM2znEWhMGtXxjv8A4IP7Z0Ku6k8CV6kpsu0jbX7iHccWoIh22OhPutqfHoyLBmAoC3dYhES6xT73hywnIpN2ItrPRRMy8E3QUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jHTr84Es; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jHTr84Es" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4629051c946so538516f8f.1 for ; Wed, 24 Jun 2026 02:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782292531; x=1782897331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+d9iI65J7drEOysA4f3uqftaNU+k5GfbGLq9UGPVdko=; b=jHTr84EsWkRZV/TctlblEg4LHeNgT/Xlk8SUjrgzqy/cbus2crH5iSUilE7jyMvAHb YEG9JVrRGPW6Znh6ZogYFPbZZ3eKdCDXgPTFKI3100068kLUryFJpUiVqeiMD4f5jC7W 1Rd/Ttk81baRKLiMLuwcEVA5zt1JPnL8bPcGWEz+DpwbUhY4wDNM0KK4UhOQlwYoWxw6 vhppr7t7pg1LSaRDZuTdZXIV+VX3KT1R6ir3j8OIzUog+6pl3LV8S9g15kza6mHNNBAY FoqdcfBweh7MKUTw0UkpiJ9RTgt6m9Xu0ZBY8c+wUuRRcy43msCRVrFwg9XUgIkZKXwZ laeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782292531; x=1782897331; h=content-transfer-encoding:mime-version:references:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+d9iI65J7drEOysA4f3uqftaNU+k5GfbGLq9UGPVdko=; b=aUNIqCMhKTnqp0fLT6R8J1cPG9spPZ1IKbUjKcbnhv+MvdCND+L2Wb6pka7C3Gf3El AO+7Jw3t7JDHa7fB2ueTnrTVgRMFSircxew078fidneP/HvJcgm1efesMBsaDPVjD/RG CgOvUi4MVhHh1kOSrkSIae7yECt0WaDYp5buGWpVUqOJMkAbp0x+D1lUTq0Buf++RAfu ZQvQawCtfg2OSMwhxYUCkh7Lh54T2okL20A0QVLhQMuDVtLgHG+sY3eDEd0bqUKazwDd s/ze0gYC3w2XPY9eTRlUcCGC7/MoQbYaN4oXPBFLOG1dx4M7DabD9o7M6ttsBDv2ccJg BHnA== X-Forwarded-Encrypted: i=1; AHgh+Rqs+iI0FmrLEb3qAUwLeJkFOrasaxphJ5A3cxL68CVw4AAVlclIBJ9GybT93pQtdERuVWhudbzLw5bfWsY=@vger.kernel.org X-Gm-Message-State: AOJu0YyGtamp/XkZiouiqRbvecaSoB5lsQGKnZnS2Iat5wuiFoRDb4Hf gGu+qOAFp2P0Upz7xGt3gyQXKC75eDgDc3R9RYlFtRoupwhjLXAJXm4COzDkVPnA3M+c6Q== X-Gm-Gg: AfdE7cmQ0ilsyMLija9A0uQ2+gt2M4GD4i/ZmcRsTupQgEnfKPE+GWeLGbcyFCwK6RC 5HgfySkcC247Klj4fw0dQFm8Lhc2gu6bni9D2Wa4AYS9mQKCbOpfcDZ5OB78VV2OhI336KCgXVF SDzipN505Oqww7iwJP9AnBurnq1b+dlz1OBvwQ7KmxlrQynBan/FQXG54QCC2vX3slk5a6vRLTG X/y2Pc//XffTSx+5yahTQjxAxUuCCgTeRTw2mgBP8a26GGfHpXv+yLxGBtB/Rj2Stl94kkRYx3n THi5O+Dyg5el8kTBxQpMGqKu+qXKGTWEr021UMS8eU5U/JPeHi/NJ+MBVLtdFckNB3hGhgfAT/B uIxeG3WlV2u/FiwfDd5N29Ucbg1chkcC0wdfWVbGK9m90FXDTP1eTL+9X5KatciA0a42Gp9Dn6p 1MsHqiv1VEJvdA95KFaH9ETjy8lsOL3g== X-Received: by 2002:a05:6000:25eb:b0:466:f40b:dcb4 with SMTP id ffacd0b85a97d-46a7efb7327mr11913383f8f.8.1782292530416; Wed, 24 Jun 2026 02:15:30 -0700 (PDT) Received: from beast.localnet ([2a00:c281:1461:c400:bf16:e4f3:7fa:c2dc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c221d93d8sm9436990f8f.23.2026.06.24.02.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 02:15:29 -0700 (PDT) From: borissh1983@gmail.com To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: sbs-battery: Add PbAc, NiZn, RAM, and ZnAr support Date: Wed, 24 Jun 2026 12:13:54 +0300 Message-ID: <5349148.31r3eYUQgx@beast> References: <20260621145952.56720-1-borissh1983@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Hi. On Monday, 22 June 2026 23:39:26 Israel Daylight Time Sebastian Reichel wrote: > Hi, > > On Sun, Jun 21, 2026 at 05:59:52PM +0300, Boris Shtrasman wrote: > > Add support for PbAc, NiZn, RAM, and ZnAr chemistries as defined in the > > Smart Battery Data Specification v1.1 (Section 5.1.30 DeviceChemistry). > > 2 files changed, 12 insertions(+) > > > > diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c > > index 43c48196c167..42a941e99155 100644 > > --- a/drivers/power/supply/sbs-battery.c > > +++ b/drivers/power/supply/sbs-battery.c > > @@ -860,6 +860,14 @@ static int sbs_get_chemistry(struct sbs_info *chip, > > chip->technology = POWER_SUPPLY_TECHNOLOGY_NiCd; > > else if (!strncasecmp(chemistry, "NiMH", 4)) > > chip->technology = POWER_SUPPLY_TECHNOLOGY_NiMH; > > + else if (!strncasecmp(chemistry, "PbAc", 4)) > > + chip->technology = POWER_SUPPLY_TECHNOLOGY_PbAc; > > + else if (!strncasecmp(chemistry, "NiZn", 4)) > > + chip->technology = POWER_SUPPLY_TECHNOLOGY_NiZn; > > + else if (!strncasecmp(chemistry, "RAM", 3)) > > + chip->technology = POWER_SUPPLY_TECHNOLOGY_RAM; > > + else if (!strncasecmp(chemistry, "ZnAr", 4)) > > + chip->technology = POWER_SUPPLY_TECHNOLOGY_ZnAr; > > else > > chip->technology = POWER_SUPPLY_TECHNOLOGY_UNKNOWN; > > > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > > index 7a5e4c3242a0..034800cd21da 100644 > > --- a/include/linux/power_supply.h > > +++ b/include/linux/power_supply.h > > @@ -83,6 +83,10 @@ enum { > > POWER_SUPPLY_TECHNOLOGY_LiFe, > > POWER_SUPPLY_TECHNOLOGY_NiCd, > > POWER_SUPPLY_TECHNOLOGY_LiMn, > > + POWER_SUPPLY_TECHNOLOGY_PbAc, > > + POWER_SUPPLY_TECHNOLOGY_NiZn, > > + POWER_SUPPLY_TECHNOLOGY_RAM, > > + POWER_SUPPLY_TECHNOLOGY_ZnAr, > > }; > > You need to update the ABI Documentation and the sysfs code to > handle the new properties. > I assume I should have two patches one that include ABI documentation, sysfs , selftest and the power_supply.h while the other is only for the sbs-battery. Or should it be three patches ,power_supply ,h + sysfs , documentation and self test, and sbs-battery ? > Greetings, > > -- Sebastian > Thank you .