mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "zhangjianhua (E)" <zhangjianhua18@huawei.com>
To: Robert Foss <robert.foss@linaro.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	David Airlie <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	<johnny.chenyi@huawei.com>, <heying24@huawei.com>
Subject: Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select GPIOLIB
Date: Thu, 8 Apr 2021 15:10:49 +0800	[thread overview]
Message-ID: <53492034-4cec-12ed-ae27-d693686084ee@huawei.com> (raw)
In-Reply-To: <a40abdd7-af43-28a3-1b79-0de6ca0c0093@huawei.com>

Hello Robert

I am sorry that I make a mistake about the compiling error of lt8912b,

the reason is that lt8912b miss the header file <linux/gpio/consumer.h>.

Although there are many files reference gpiod_set_value_cansleep() and

devm_gpiod_get_optional(), they all include <linux/gpio/consumer.h>

and not occur the compiling error like lt8912b. I have send the second

version patch, please read.


Best regards,

Zhang Jianhua

在 2021/4/7 17:50, zhangjianhua (E) 写道:
> Thanks, I will do that.
>
> 在 2021/4/7 16:03, Robert Foss 写道:
>>> Yes, you are right, there are many files reference
>>> gpiod_set_value_cansleep() and
>>>
>>> devm_gpiod_get_optional(). How about add config dependencies for all
>>> releated
>> I think this is the way to go and roughly half of the drm bridge
>> drivers seem to need this change.
>>
>> Do you mind submitting a series of patches adding this fix for all of
>> the relevant bridge drivers?
>>
>>> configs or only add config dependencies for the top level config?
>>>
>> .

  reply	other threads:[~2021-04-08  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  9:07 Zhang Jianhua
2021-04-06 10:21 ` Robert Foss
2021-04-07  7:50   ` zhangjianhua (E)
2021-04-07  8:03     ` Robert Foss
2021-04-07  9:50       ` zhangjianhua (E)
2021-04-08  7:10         ` zhangjianhua (E) [this message]
2021-04-08  8:22           ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53492034-4cec-12ed-ae27-d693686084ee@huawei.com \
    --to=zhangjianhua18@huawei.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heying24@huawei.com \
    --cc=jernej.skrabec@siol.net \
    --cc=johnny.chenyi@huawei.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robert.foss@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®