From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbdAWLy2 (ORCPT ); Mon, 23 Jan 2017 06:54:28 -0500 Received: from mail-by2nam01on0044.outbound.protection.outlook.com ([104.47.34.44]:46880 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750908AbdAWLy1 (ORCPT ); Mon, 23 Jan 2017 06:54:27 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c: 2 * pointless local variables ? To: David Binderman , "michal.simek@xilinx.com" , "soren.brinkmann@xilinx.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: From: Michal Simek Message-ID: <534e45bf-8a2c-85e4-e18e-0c95a9f97e40@xilinx.com> Date: Mon, 23 Jan 2017 12:54:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22838.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39850400002)(39840400002)(39450400003)(2980300002)(438002)(189002)(24454002)(199003)(2950100002)(31686004)(189998001)(230700001)(36386004)(23746002)(63266004)(83506001)(9786002)(38730400001)(31696002)(8676002)(81166006)(65826007)(5660300001)(2501003)(81156014)(77096006)(305945005)(86362001)(626004)(8936002)(39060400001)(356003)(2201001)(229853002)(92566002)(50466002)(36756003)(2906002)(64126003)(76176999)(54356999)(50986999)(65956001)(65806001)(4001350100001)(5001770100001)(106466001)(107886002)(47776003)(33646002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR0201MB0753;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT064;1:fTavQJfAn7SjaKs4x5DDzyvNU8JWVJOkHzNu9K8GhJfUZcuFvnAUGueeP2+445OGYI2ZiBarDEi2lcZ6qAUoKGmDwH85BH/7zsZXNFr8tdbpKJmdtcvMTYXivn0wtt8IDJJ3loX8OSALgjkaWBcfpzZy/eilNU1WOFW2xH/4n0BfYaWfy/lCFr2XrP0xRbaES3HWJoIc7WLiw/kRZc1hfkKsLQpTbptAFrio0zrjaagFA9xL3skI7sSCByhZFJc+2+hS50mR4EV7NW7jcPpRxgjbobzMIBfUaUzhVfcteQKKwt6xpnXH7Gqwk95mCW5FW9sc1wtf3SOCaKQ1PYnwMkPVAT1qJzvxB18kS4UYftqpYjSSfSx+WU0jhsHKaOO4fGQIP+4cf0KAOp7TDthhuXt2QofUaw3R4mKnBmD+8FC4AXn8tc1O27wobiG/vvPxjfm9TWuqNSlxwotQSfn49l2rBzy5OP1U4Itiz9/n99276SRkwXbKQ9Yr4fYEYldH+VjBx8IyWqQOOY6PKbLlPdR13RdXiazI1xaq33bEsXa/Z610jBO3gb1zFQ1WoUvETxD/vOReKuqkjP31LAWDjHnAjKeUV/dxST63PHeAGtY= X-MS-Office365-Filtering-Correlation-Id: f17a588b-1692-47bc-849f-08d443869379 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN1PR0201MB0753; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;3:oF1AreskC4cxcHiOjyrofR6wJwftXZ/Gos5uCiI0Xq72aUHpT+WON0Vn7Kh1Jtx3rnXZLVWYktnyGBLlk36xRGbDS8+jcEDXyp3oyii48ou12/JsAzHzBMJfgTfyubk/4vXfkRejRWaAiRBSyzdOnx2MkTRm7eOZ7J0Jk3GOldCwK8XXCQkkmbo7iYTCjyfqlfNUpvIkQruzARw+QnasM0N4oLhx417a7PrWbIxhYk6aptyEMZlnL7iBZi2EaY0L5bU3EkwnWhmPzqSFo4Fnwvf5gRrTO5FtJM840oqDo9/ebUR1xnxPiwo/pWZUUHqrvX++JHRM8xiValJzzN5gn9hT0/TE2G3kAUrf/v1n6aWy2GEnNRW/dXbv+BnYHd0j/yJGweFP+ycApVCnReobUw== X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;25:O7D3SgA8HX042UB6N1AZnT6ec2i0mDCCu/eq59aGFx+HHKRVRZQMRFYKdRugMY6H6/QQTRc0EJcWFTrGWI8hvBpVgo2I4SZY5T2Z7j8SPyc9du/v8dDLrHoiH+u3LgXCFIfod+U4huGDgngFjkBsP25uE1HFYZN9L3CUD8sAHY78MPbxLszOTt442Pq+Q4JGXSK2lUD6rPv6VvWnLKiYr3SfZ2U34cBnblenk9iUj24rLMQ4ZLfbrA2pR7LftdAe6z8W3w58IscI2Rl6J5PBGalkK78S3kKiWsYZCm4JjTB5MsCsIKtlrBu0snKyLF1dOcoTYr1OFYIt7b3LSh8Ff8+UE0pJt0PJN+RZ9ljspknDZBzxbl48Jo0Fgc+Oo+nXdSl0WKbTzdKoMRaxP1eFs//KzQdBnMqoyjH1rYuPWg+W5pw3VOrqmcvWXOlNOV6V2bT7VTc3Sn3CAkVzi2JGSST281cZjsULi9oLtS5JuvapBphFyTzSENZq+imnCHBNSzOeMbzeYG4rxbZKW4G3khS15lszQtmI46RWOCR28dkYJkLmJYsbL+HRFItoTyXKHlqoeMoe1PlC7kpABJRZnBqkWEXJCt9XmcpADYBZT4yLs/kjsBrs/A8+IXkPwFndcZFBJQEsAy6/QKnk/AK+RNziBbmU1e53dk2tFRtyq3vh/GgwLayoickbOAZdWlnvUP/+5Kg4A8LBFRpSRoNI+1wikhE2X9Hdya3RmX0ZmBGesMgVmwwrYV9C2SW6Bj2hNIKv+wPh3XfftlpT+lz7rO8Ph1dsM3rm9VXfgbhA0I0befZ0VNI6CjLGTpgF41YSJa1VN2sUOWDSwW8ggMq4pg== X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;31:l12QYnw4FmPheQm5x1i4hmbTHKI0Cp5kEpdT7UB7FAUJyPkWPGayukXyI9xRL2soZ0O3u0LD/BtTCC0ZdN8AO8rEWEUeqaT6VSVMW82jVR3gSNmSRj8Pw2cGIvjr0RQaD7gSm143TdALvgu4a+aBXCav0QacRwrGnyS7AldKd8hpG1UVVa9RrNhUPg7Y/kbyWrjhS2gvF5g0/vq/w4wFBSsPoTIGbi2CaC6o3SKhTUmEfktSZp+CmsyxmEhcXnI9gjXk5p7vjVXHbl3y8SIlAw==;20:smieps3eCaVplmkJ1/sK27a5dycyVcSkQmn6vY+DvNqf6yR3UcgjEnZWyx9wJguZUZZ8GmtEDpXM5gAMcr2QNe/lx3hGk9/g3cIZa73AN0itqWqowgGRZ1AEoAYQ9902eotrXi0PIDy6O/A6udU3STzEBcNgKjQVxWsKmA+K/Rm+HwIevAdXhiAhLkkBFtgfUMluxI8+m8d+CmAT6O2CKCIEoYMHZapp6rSp+sZdHHPPF0xNnjZFVB2itkIYqx4G4zDx9lHeROYuV/twBt9GAZfuIAxUgZvmkhMbOAQk3bFTdZC2lrlVwbwXsvK1P273vW0bitr4QnMSit9eP+N4/b1cuFR3bqv5Eb69jtGuwLH2Ij1v5ffEmJeTSDSJiYd0LPPq1jgYJh1dPcbbbKSPR5Uda1W/raaTvIWWtGgAibKCpMZ/XIwpcdUwEk0GJjz3vIOIVSt6pT4jPMLj7kyhuivWyeEjAxcckJ0m+STexS7R0sVF0PF0u3UsLtf0C6ar X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BN1PR0201MB0753;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0201MB0753; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;4:p7oM0ZLj6frh+4xCLwUu8f28JDHAOUz0EPvMH1B7zAO1uUtyDpZ2C3aT5nKLhrrJ50k6c3xgYA506pAFDrNxXtPTjGwt/cHG1h4BSAhiGHhPeg6NXJSmig9EadQn1RVcu2STASV+F5ZxDuyV8me/DnxpZPO7I6cHZDmiCZfqqUJ8VRNfpR2GtAGQDR1HnOIhXzAU5zUw1TkBJE/EAPh9yiND9mv9gdvPVDDVlArzZiCsACplsq6x0fvMSbDQAD5izI+HFw6hFEwTyeDdL6GIiKncU+o4tx+wygtOex19+5iUhpV5LvBiOFbxsxqj/ayeQ82WSXwmbIW2HiENtZnY8V0s9xo6Ue7vAcZGRc4OQA4BbRsEkAX/9M362uVMD/hYu5UD8ETOg1mtumsFOK6byY+FGDAuW9Lp2n9KKWQfiwEmpiNoTSS1jfQ4HtFZTXK++Y+Yoy4886EqZ0PX6d2WCOl4asXWgM9zIM3hAQGckbSDpJjyEzL8TJJ9OaT5AAkAmbCLxRQnWLC2AcUeknAZKhJYLXzMNyAlFmAaxqbxEHXyqA3X9b8lX3LzGBnOsQHINuNqepibb9Zq+65r8M6hFea70yA4txpIqCtDMK2w8pxJ4C4yI6IapU6NRt1ch9yjTi4nsPJpxsxthJUVlwJoM1welGSHQ3K5dkxxuNFCHRYwzCHGgiSu9dG7lUGGAWjf X-Forefront-PRVS: 0196A226D1 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1PR0201MB0753;23:3tY/akfyWbYDocIEaHVA1MsVCUP8INAL6YE?= =?Windows-1252?Q?rOLQOy9W0bYLXHgs8xmPmuEQHu2kf762CujAIBDg80GjK0+j7n2njgeS?= =?Windows-1252?Q?c7I6yo24b1+oWKmWJPUt5mYj90liyRSjtHq6JhLfUy13Mhdm/3hvOs83?= =?Windows-1252?Q?7DISHxaUtyKB0U+NU6KLzc+TE7zhRiFmwfkteZeKNWNboNb0lGr6ndcn?= =?Windows-1252?Q?kqCcYjt3W7lq+nDeZ1iXPXrbaTAKiGJxoqkhiRNOgEcykgo0UKVC0jXj?= =?Windows-1252?Q?RXGSJ9vULYobn0eGSxt/xXdygbgslO+wlyKpdMpexDCJlolY9QkxYNpP?= =?Windows-1252?Q?8APuUa2QwzHYUbdZhTalMPb4dj8njaMtp3NYZqRNNBmS/cAcpowcRQc6?= =?Windows-1252?Q?NhzPaf96cFywU3gV62HYyEq2W8b8Fjl2+ylg2XdJn0y0UeinwxXPQoPB?= =?Windows-1252?Q?8q3IUXThTXwRgi9CfBaXtvsj43KWv5m8RLK4r/QD04bix+7dj1RswCcF?= =?Windows-1252?Q?87IojuxXquJ6GK1GNx1NT/XCi+VGRWaYGE+HXq3K6Ru+Jsc8qCj4YmES?= =?Windows-1252?Q?8/8o4PJl+Cx1qDpB8uKKiphTeWpX9LE813+FOCPLp1sAmObO/2ok40r8?= =?Windows-1252?Q?Deo3w1B+WODYyits5oml8kSQcFP9ChaclEJdqrmsKrYqDbhkZAi69f6D?= =?Windows-1252?Q?SVNb/tjLj1A5kHJ8KsZziqsEFK6cdArKv8u+o/s7H1KTioZWBfMcruXg?= =?Windows-1252?Q?ENipxQznSHTM+fLFju7FD2dKyeqX54qy1TYadwbN3sYLL3D+bAUCcg7P?= =?Windows-1252?Q?g1eAtsXEBw+90LZbBt0Hb6Ffy6+zHl7VHRT/eyG3S0kGp36M9TwyaZQw?= =?Windows-1252?Q?W81q82aCoI1iwdzt3P0UtYYz1eyIE86zQUBVN/+yuTahAn0E3jVFTsRe?= =?Windows-1252?Q?eGLc3qic7/JzltjjpiY26CrTu4hrhAo3MKOyWSjR7w98jaR9EU2SYjUA?= =?Windows-1252?Q?CxNAtd+9b5zGQwHZB8Pu27Fo+sFYhjPKGxmwIOFk3BheNSiIws70s37M?= =?Windows-1252?Q?gOEHEZsMKHD55FavyAOm24Nm51mf4t0Snt34Cx3rdFM3F/Ja9h2wFkUq?= =?Windows-1252?Q?MFFPd4S2RSDws/gGX4COh3SRcqcYi6T+c/ebgGGcnxRjM+NdqDdHif3s?= =?Windows-1252?Q?iBHja84TM4NG8VvokVbJYFSlW1rtLAo1S7yndbKf7iQPsrtFxBvvHqQV?= =?Windows-1252?Q?piIfn4x0EwmIZyTe2gsHGuV9zbRx7k67JIVNAoKTYOj73zZ8eHCoc/YS?= =?Windows-1252?Q?jwoJBpqiPai4woKzuu/J8/QN8J7iCZABqbpl8iF6qsWgYPE/mbCQ2acr?= =?Windows-1252?Q?Dm6JtwBW7Ro8UEFfzotlUypQYhKl+8HrA4QKPlVCR8AFmrlWGkIrBXyk?= =?Windows-1252?Q?tVL3RU984YESygtBnvKIfWx+aOyXWGs+KAOZHK2mD2g=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;6:8cm9zbGIpnCX0KixuFXyIjSTHImounz6wWqi9+lu/bk1GjLlYaHTT8otdDoGIGaGPm7bXx0z/s1QhhbufkehVSjpmwB9VZaPpsax5OCr2WEGdwQdFbsFtY1MuqbJLZQYa0Rg/zRGN5KJ3OnNLzpMYoLyMOIWBC7KAc6xlW1S7FchKKhLMNiNjV4wKHnsxXnbWmZQhecrjMIMN13veob65cQ1eatIQ29UR5ae23ZrYPqXHqJIc/JKEIjsDS/IWb6wXyzacGsRiDqw+ryGUC50hdEsEQ6UQYN0SXgmsTCZBFkZx4w824JQ2cvYV2FdfEA/nwVMDNlF6UYj4+V1GqUm9R/vkiPQ1LIolK6Eol1djuCu6UeJ5qqK9dC6fZLQPzXSjIZGX/r4Ui+eZy8JroCSg8yFvG6VfNSoXTPSI3xlPEgAJrDy6bOG2es7doY0X80QMYqxxZAjYB2+YqaeyElaBw==;5:LkQTOmEx6oKzlAqgTEswriEQt8pyl9IG0pW9U12bMcEWfKbakH/2trxVRkxiN30b75b98yZOPkErIp93d9XcosPvK13dC16jlIuXIIOHWlbDihCO7d0ACE+745bP8iD7sUQs8H9uEBsYy/gKJOoEtw==;24:u4PPgWhpjq7xyo5hNhLbZNKri+vvRJdHK4i/bxqdQdm8eX81iRVESlIOZg7SFFheyvAq0XfjnCu9Gkje5UJICCC0ppkN3o5lRIO/07ob0GA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;7:yTR1rlrleXxAZaa128rYn6gd5tUAQJ2pBcpbcfttLXbj3shIX+vX0GNqzcxwk+eUWiUVeA1+sy1MWGpRyky4KW43I8vXbFxhfsBqBy//zPHqKfNj/6nLcoaMDdP9KUu0WLjwtMYOB1aN+1zihcW2orgimx2vtksP6SRToC89zRaK7uRXxIJVrYu+JmTSKGSUFf2Bwb6N2N+cHo4BYtc351+3w/IjGm1Y7PBv0NLwfaN4R0sZLg6+KK/8ns/24k3RfCdL1I8TvBiO/Tnqu2W9vII0zfDTWcaaitiRRDbFU3u7aAY9wWXa3zCggDwBA4MlczwHG4jW1WiEWUs14/OlI/ypnZKVELtNujyY8YS1Me9fAMhIvknSFIJ3VL+vtlcd5wSMw/WHnLximtlJq45EgTMIDmSoVjwj3e+7kq/0PsGtd8pL6TjiysYcSmAv9FPM/QGqtVba7itr2gJ/mjfGvA== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2017 11:54:24.2319 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0201MB0753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.1.2017 12:39, David Binderman wrote: > > Hello there, > > [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:301]: (style) Variable 'num_writes' is modified but its new value is never used. > [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:356]: (style) Variable 'read_count' is modified but its new value is never used. > > Suggest either use these local variables in some way or delete them. > I have sent patch which removes them. Thanks, Michal