From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: qcom: sm8250: clean up wcd938x codec node
Date: Tue, 3 Jan 2023 14:37:22 +0100 [thread overview]
Message-ID: <534ecce6-54b3-7b7a-9c92-48e0b810edc0@linaro.org> (raw)
In-Reply-To: <20230103103141.15807-7-johan+linaro@kernel.org>
On 3.01.2023 11:31, Johan Hovold wrote:
> Clean up the wcd938x codec node somewhat by adding newline separators,
> reordering properties and renaming it 'audio-codec'.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> index b741b7da1afc..0991b34a8e49 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> @@ -23,18 +23,16 @@ aliases {
> serial0 = &uart12;
> };
>
> - chosen {
> - stdout-path = "serial0:115200n8";
> - };
> -
> - wcd938x: codec {
> + wcd938x: audio-codec {
> compatible = "qcom,wcd9380-codec";
> - #sound-dai-cells = <1>;
> +
> reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
> +
> vdd-buck-supply = <&vreg_s4a_1p8>;
> vdd-rxtx-supply = <&vreg_s4a_1p8>;
> vdd-io-supply = <&vreg_s4a_1p8>;
> vdd-mic-bias-supply = <&vreg_bob>;
> +
> qcom,micbias1-microvolt = <1800000>;
> qcom,micbias2-microvolt = <1800000>;
> qcom,micbias3-microvolt = <1800000>;
> @@ -44,6 +42,12 @@ wcd938x: codec {
> qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
> qcom,rx-device = <&wcd_rx>;
> qcom,tx-device = <&wcd_tx>;
> +
> + #sound-dai-cells = <1>;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> };
>
> thermal-zones {
next prev parent reply other threads:[~2023-01-03 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 10:31 [PATCH v2 0/6] arm64: dts: qcom: sound cleanups Johan Hovold
2023-01-03 10:31 ` [PATCH v2 1/6] arm64: dts: qcom: sc8280xp: disable sound nodes Johan Hovold
2023-01-03 10:31 ` [PATCH v2 2/6] arm64: dts: qcom: sc8280xp-x13s: move vamacro node Johan Hovold
2023-01-03 13:35 ` Konrad Dybcio
2023-01-03 10:31 ` [PATCH v2 3/6] arm64: dts: qcom: sc8280xp: clean up tx-macro node Johan Hovold
2023-01-03 10:31 ` [PATCH v2 4/6] arm64: dts: qcom: sc8280xp-x13s: move wcd938x codec node Johan Hovold
2023-01-03 10:31 ` [PATCH v2 5/6] arm64: dts: qcom: sm8450-hdk: " Johan Hovold
2023-01-03 10:36 ` Johan Hovold
2023-01-03 13:36 ` Konrad Dybcio
2023-01-03 10:31 ` [PATCH v2 6/6] arm64: dts: qcom: sm8250: clean up " Johan Hovold
2023-01-03 13:37 ` Konrad Dybcio [this message]
2023-01-18 22:50 ` [PATCH v2 0/6] arm64: dts: qcom: sound cleanups Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534ecce6-54b3-7b7a-9c92-48e0b810edc0@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®