From: Hans de Goede <hdegoede@redhat.com>
To: Mark Cilissen <mark@yotsuba.nl>
Cc: linux-acpi@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] ACPI / x86: Work around broken XSDT on Advantech DAC-BJ01 board
Date: Thu, 3 Mar 2022 18:56:26 +0100 [thread overview]
Message-ID: <535336dc-8c54-7c3a-ecf6-b2920ea99297@redhat.com> (raw)
In-Reply-To: <4BBB58DC-653C-4373-A5F5-9239C86C8AE8@yotsuba.nl>
Hi,
On 3/3/22 14:42, Mark Cilissen wrote:
>
>> On 3 Mar 4 Reiwa, at 14:38, Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi Mark,
>
> Hi Hans,
>
>> On 3/2/22 21:20, Mark Cilissen wrote:
>>>>
>>
>> I think that there are a lot more boards that will have
>> DMI_BIOS_VENDOR == "Phoenix Technologies LTD"
>> then that there are boards that will have
>> DMI_PRODUCT_NAME == "Bearlake CRB Board"
>>
>> So if you want to make the DMI match as specific as possible then
>> IMHO dropping the bios-vendor match is best.
>
> Of course, but just to clarify -- my proposal above is to drop
>
>> DMI_MATCH(DMI_SYS_VENDOR, "NEC”),
>
> not
>
>> DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board”),
>
> . :-)
Ah I see, I did indeed misunderstand that. Still NEC is not that
often seen as sys-vendor, so I still believe dropping the bios-vendor
match is best.
Regards,
Hans
prev parent reply other threads:[~2022-03-03 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 4:08 Mark Cilissen
2022-03-02 9:02 ` Hans de Goede
2022-03-02 20:20 ` Mark Cilissen
2022-03-03 13:38 ` Hans de Goede
2022-03-03 13:42 ` Mark Cilissen
2022-03-03 17:56 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535336dc-8c54-7c3a-ecf6-b2920ea99297@redhat.com \
--to=hdegoede@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark@yotsuba.nl \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®