From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbaDYKOa (ORCPT ); Fri, 25 Apr 2014 06:14:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbaDYKOW (ORCPT ); Fri, 25 Apr 2014 06:14:22 -0400 Message-ID: <535A356E.8000205@redhat.com> Date: Fri, 25 Apr 2014 12:14:06 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Kefeng Wang , Tejun Heo , Maxime Ripard , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org CC: wangkefeng.wang@huawei.com, xuwei5@hisilicon.com Subject: Re: [PATCH v6 0/3] ahci: add support for hisilicon sata References: <1398416351-30567-1-git-send-email-kefeng.wang@linaro.org> In-Reply-To: <1398416351-30567-1-git-send-email-kefeng.wang@linaro.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/25/2014 10:59 AM, Kefeng Wang wrote: > change in v6: > 1) type of host_flags changed from unsigned int to unsigned long, > fix the building warning and error. > > channge in v5: > 1) drop AHCI_HFLAGS(...) from ahci_xgene.c and do use host_flags > in ahci_platform_init_host, it's my carelessness. > > changes in v4: > 1) add a dynamic host_flags parameter in ahci_platform_init_host > to make it more flexible, modify some driver to use new > way to pass host flags, suggested by Hans > > changes in v3: > 1) move NO_FBS chunk after YES_FBS, Tejun's suggestion > 2) use ata_port_info pointer to avoid struct ata_port_info > on the stack twice > > changes in v2: > 1) make code more concise according to Hans's advice > > Kefeng Wang (3): > ata: ahci: append new hflag AHCI_HFLAG_NO_FBS > libahci_platform: add host_flags parameter in > ahci_platform_init_host() > ahci: add support for Hisilicon sata Thanks, looks good: Reviewed-by: Hans de Goede Regards, Hans > > .../devicetree/bindings/ata/ahci-platform.txt | 3 ++- > drivers/ata/ahci.h | 1 + > drivers/ata/ahci_da850.c | 3 ++- > drivers/ata/ahci_imx.c | 3 ++- > drivers/ata/ahci_platform.c | 9 ++++++++- > drivers/ata/ahci_st.c | 2 +- > drivers/ata/ahci_sunxi.c | 9 ++++++--- > drivers/ata/ahci_xgene.c | 7 +++++-- > drivers/ata/libahci.c | 5 +++++ > drivers/ata/libahci_platform.c | 5 ++++- > include/linux/ahci_platform.h | 1 + > 11 files changed, 37 insertions(+), 11 deletions(-) >