From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC9E37647F for ; Wed, 4 Mar 2026 17:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772643930; cv=none; b=QkEgK3HUrdti5YhOumrh9/AgnNJJpLy5YdGZz2BC6cX2A2+52m+YZjBypG/je13TPgdPBpskaB2SKcneN2P1meP7LcsbTnoGQt6b+jOGQ9tMSok5RS89MSYMmsIQkdI30Sbc1mWRUq8jU4FpGOw3sUc6b1ZnT7mP17JiaGdtfGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772643930; c=relaxed/simple; bh=OH1iVEGyufKJWZ6nGRBCTh5TbGVr0ahXb5ytegQDXX0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pqrqXDW36tmzuG7YPYKixWzAsHws8KqgbSm8SlEgRkxIj8lUhtQ8LmSck/FIdS41qryb0k5cum4AsX5fdffSeCePZ4umtaPP+MRylP1Kpmq83Ldgi0lSa9IvtJNen3iN5VI2xvd3+R+x7gqBI10uOgJfANx0uwkd2sDzXe+z1nA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gUa6ToLm; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gUa6ToLm" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38a01c80c34so97034251fa.0 for ; Wed, 04 Mar 2026 09:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772643927; x=1773248727; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nBw1fSxD2dFeBYtvLIBCd+WEBb8h9+p5M44FyAJ5Xvo=; b=gUa6ToLmuWM0OrLv9AywbGnfujj6GZ/nmEOwOXc6G/RWspZDdCLfILCNws6RkqJSPA 8b/zjyw/nPBoZ+d40aC3l0Xz1zXF31bvrXujZtKrLT+cSKbcF0QJQ69LyIFeD/0zZRwD go/box5xt6durT9zXwl26ORkbsoddFFa0qz6Q2lteOcbVTOwvxFBY0qkfb4Bjkw2G0Rf c9nAOI2YdjNix0jmzo9lugkSHKDpAqBD5Of0i+x8QtIZk0QwpWlyrH7JnATiIT9/v7dj goClXYYF9hoetfca1DUcmnP1/OZWMKhT6fQfRe/cnl3WKQbuS1P8ssEa9U7uy99qxVcB WGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772643927; x=1773248727; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nBw1fSxD2dFeBYtvLIBCd+WEBb8h9+p5M44FyAJ5Xvo=; b=P357eP8VAOwb77dw3ohfceIz919Zemc7NHOnWuA6sW4Og3kZfl+TsugKlIhq+yRmbj rG6/4Z8agVCYVfIaqSJYY2xZPaVDL++5HX5Uwug5QBmZihnsooszepA/kvvf1vC003xn HEP0QrFUN0kXFEESKrE1IWzXDOENuwWhAd3bXyyPXk0vfE13FQ8++xtM4AdQvSD3ctKC WcPNxX63CDn0CgayY2+WNYXhK5EoRjw8XefUKS40bLryy9qTbtgfug9EtWAcVAC2jGK9 D6sUSZi9UfuzKfi1Be5AQg88w1YKhqAPgUThTgr0hGBn+TAWrzVMHcEynbWQLdU+Er41 SJ/w== X-Forwarded-Encrypted: i=1; AJvYcCWjNoDGNWd+1kePurYmh2z2sqIEnBFVUlmAPPqu4kxIvnVnssr2hGWFaCOKCzGnntllDl70fP2R/Cu8iks=@vger.kernel.org X-Gm-Message-State: AOJu0YypxCK4/pBu5p4D1dTUzOizqOZgpU2GD87NCdS7TbcSSSFyG8d1 rxgbSbmO8EmGJbMq8YTgp+xdo6WQL35oXAAz7V7et86GxQEwAdmpPmE2 X-Gm-Gg: ATEYQzxRkSh9I3DQvY1tPWARqVrZOqxTnGJGOWWH60hsIDzMqgQdAAUdaM1j/b0HmwM hU1YiJ1vYyYMpyyBH7veCWN39GdnZioB7GUjxI+HLFSSPxn8+inI+58/h5ZJqfG2bkDuoHuFt+t TMh1CE5jRxaxaT2/pNyttCHiC3hTMwYiVXtyzS5jEOe4VpxS5OXhURNvozLWEd1T/LU8Wf1Ec0G oGQG4dBMc3JN+ssFoFUKcd5D+7Gz7uC5RY9CuQPb4oD3neDqjEZTLBM0Or9PLtdywgRmd+n7Iyk 0yaDh9AdcdcLHOTFsfDO7/2w+P0CcN/vQvrvqYgNp3c9xQNCEbp9CFC2oL3x/ozGc9h7rdA0lt/ J7M1ILuSF77ZaxOyjSt4oqTKjHU5XCGdwba+tdI233GxfZWwNxpnB9KQUFmReyKIbYj+LjhDoa0 2UkicTcs/HQkANbMJIK6icRb95ixJu7Zv8a4NA2StYtHisG77xSFG7LhMFMbqMGA2m7Gafy+Iah 5Y9ZM+srW/1tr4= X-Received: by 2002:a05:651c:41d8:b0:384:9355:6a7e with SMTP id 38308e7fff4ca-38a2c5906e9mr21403371fa.17.1772643926140; Wed, 04 Mar 2026 09:05:26 -0800 (PST) Received: from ?IPV6:2a00:1fa0:2f9:5688:1071:60fc:93b:c6bf? ([2a00:1fa0:2f9:5688:1071:60fc:93b:c6bf]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12d81b51fsm397959e87.84.2026.03.04.09.05.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 09:05:25 -0800 (PST) Message-ID: <535cfe49-4f70-4ed9-ae4f-92215140e6f6@gmail.com> Date: Wed, 4 Mar 2026 20:05:24 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip/gic-v3: Print a warning for out-of-range interrupt numbers To: Geert Uytterhoeven , Marc Zyngier , Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <62b849967d71d73e028fb65efee717986ef847e6.1772641758.git.geert+renesas@glider.be> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <62b849967d71d73e028fb65efee717986ef847e6.1772641758.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/4/26 7:31 PM, Geert Uytterhoeven wrote: > gic_irq_domain_translate() does not check if an interrupt number lies > within the valid range of the specified interrupt type. Add these > checks, and print a warning if the interrupt number is out of range. > > This can help flagging incorrectly described Extended SPI and PPI > interrupts in DT. > > Signed-off-by: Geert Uytterhoeven > --- > This would have prevented the issue fixed by "[PATCH] arm64: dts: > renesas: r8a78000: Fix out-of-range SPI interrupt numbers"[1]. > > [1] https://lore.kernel.org/1f9dd274720ea1b66617a5dd84f76c3efc829dc8.1772641415.git.geert+renesas@glider.be > --- > drivers/irqchip/irq-gic-v3.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 20f13b686ab22faf..d75163e71bf22473 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -1603,15 +1603,27 @@ static int gic_irq_domain_translate(struct irq_domain *d, > > switch (fwspec->param[0]) { > case 0: /* SPI */ > + if (fwspec->param[1] > 987) > + pr_warn_once("SPI %u out of range (use ESPI?)\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + 32; > break; > case 1: /* PPI */ > + if (fwspec->param[1] > 16) Not 15? Don't PPIs use INTIDs 16-31? > + pr_warn_once("PPI %u out of range (use EPPI?)\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + 16; > break; [...] MBR, Sergey