mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Zeng Tao <prime.zeng@hisilicon.com>, <gregkh@linuxfoundation.org>,
	<stern@rowland.harvard.edu>, <mathias.nyman@linux.intel.com>,
	<drinkcat@chromium.org>, <felipe.balbi@linux.intel.com>,
	<drake@endlessm.com>, <ravisadineni@chromium.org>,
	<joe@perches.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Thymo van Beers <thymovanbeers@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	David Rientjes <rientjes@google.com>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3] usb: hub: try old enumeration scheme first for high speed devices
Date: Mon, 20 Aug 2018 09:55:49 +0300	[thread overview]
Message-ID: <535e6c93-4369-c01e-953c-35e7041129e8@ti.com> (raw)
In-Reply-To: <1534759484-44744-1-git-send-email-prime.zeng@hisilicon.com>

On 20/08/18 13:04, Zeng Tao wrote:
> The new scheme is required just to support legacy low and full-speed
> devices. For high speed devices, it will slower the enumeration speed.
> So in this patch we try the "old" enumeration scheme first for high speed
> devices, and this is what Windows does since Windows 8.
> 
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>

You need to add Alan's Ack here. I don't think you need to resend though.

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> Changes in v2:
> 1. As suggested by Alan, mention in the commit log that this change is
> follow what the Window does.
> 2. As suggested by Roger, update the kernel-parameter description.
> 
> Changes in v3:
> 1. Remove the blank line suggested by Alan.
> 2. Tag applied.
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 3 ++-
>  drivers/usb/core/hub.c                          | 4 +++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 533ff5c..95db23c 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4453,7 +4453,8 @@
>  
>  	usbcore.old_scheme_first=
>  			[USB] Start with the old device initialization
> -			scheme (default 0 = off).
> +			scheme,  applies only to low and full-speed devices
> +			 (default 0 = off).
>  
>  	usbcore.usbfs_memory_mb=
>  			[USB] Memory limit (in MB) for buffers allocated by
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 1fb2668..003fac0 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -2660,11 +2660,13 @@ static bool use_new_scheme(struct usb_device *udev, int retry,
>  {
>  	int old_scheme_first_port =
>  		port_dev->quirks & USB_PORT_QUIRK_OLD_SCHEME;
> +	int quick_enumeration = (udev->speed == USB_SPEED_HIGH);
>  
>  	if (udev->speed >= USB_SPEED_SUPER)
>  		return false;
>  
> -	return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first);
> +	return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first
> +			      || quick_enumeration);
>  }
>  
>  /* Is a USB 3.0 port in the Inactive or Compliance Mode state?
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2018-08-20  6:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 10:04 Zeng Tao
2018-08-20  6:55 ` Roger Quadros [this message]
2018-09-20 10:37   ` Greg KH
2018-09-28  3:24     ` Zengtao (B)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535e6c93-4369-c01e-953c-35e7041129e8@ti.com \
    --to=rogerq@ti.com \
    --cc=corbet@lwn.net \
    --cc=drake@endlessm.com \
    --cc=drinkcat@chromium.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mike.looijmans@topic.nl \
    --cc=mingo@kernel.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ravisadineni@chromium.org \
    --cc=rientjes@google.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=thymovanbeers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®