From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Keerthy <j-keerthy@ti.com>, rui.zhang@intel.com, edubezval@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, leo.yan@linaro.org
Subject: Re: [PATCH V2] thermal/drivers/step_wise: Fix temperature regulation misbehavior
Date: Fri, 8 Sep 2017 15:59:07 +0200 [thread overview]
Message-ID: <535fbdfe-6e6b-84b1-90b8-592aed46c6b2@linaro.org> (raw)
In-Reply-To: <d2fc01f9-c9d9-4247-2baf-6e544e5ef172@ti.com>
On 08/09/2017 14:25, Keerthy wrote:
>
[ ... ]
> This definitely is an issue i have seen on dra7 and if step_wise by
> design can accommodate this change, It will fix the issue!
Ah, ok. I understood you thought we should not do the change and use the
DT crit trip instead.
> Then you should be updating the documentation as well.
>
> /*
> * If the temperature is higher than a trip point,
> * a. if the trend is THERMAL_TREND_RAISING, use higher cooling
> * state for this trip point
> * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
> * state for this trip point
>
> Now with your patch applied the point b. will change to:
>
> b. if the trend is THERMAL_TREND_DROPPING, Maintain the same cooling
> level till the temperature drops below trip point.
Ok, I will change accordingly.
Thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-09-08 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 6:58 [PATCH] " Daniel Lezcano
2017-09-08 3:05 ` Eduardo Valentin
2017-09-08 9:05 ` [PATCH V2] " Daniel Lezcano
2017-09-08 9:49 ` Keerthy
2017-09-08 9:51 ` Keerthy
2017-09-08 11:47 ` Daniel Lezcano
2017-09-08 12:25 ` Keerthy
2017-09-08 13:59 ` Daniel Lezcano [this message]
2017-09-08 14:12 ` [PATCH V3] " Daniel Lezcano
2017-09-11 10:04 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535fbdfe-6e6b-84b1-90b8-592aed46c6b2@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=j-keerthy@ti.com \
--cc=john.stultz@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®