mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: <david.vrabel@citrix.com>, <xen-devel@lists.xenproject.org>,
	<boris.ostrovsky@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 6/6] xen/pciback: Don't call xen_pcibk_config_init_dev when device de-assigned.
Date: Wed, 30 Apr 2014 15:40:39 +0100	[thread overview]
Message-ID: <53612787020000780000DDA0@mail.emea.novell.com> (raw)
In-Reply-To: <1398866051-32714-7-git-send-email-konrad.wilk@oracle.com>

>>> On 30.04.14 at 15:54, <konrad.wilk@oracle.com> wrote:
> When the device is de-assigned from a guest (but still owned
> by xen-pciback) we would needlessly free all of its dynamic
> entries.

I wonder whether that isn't intentional - dynamic fields are only
being used for what comes through the "quirks" attribute.

> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -288,8 +288,6 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
>  
>  	/* And cleanup up our emulated fields. */
>  	xen_pcibk_config_reset_dev(dev);
> -	xen_pcibk_config_free_dyn_fields(dev);
> -

Irrespective of the above, patch title and contents are out of sync.

Jan


  reply	other threads:[~2014-04-30 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 13:54 [PATCH v1] Documentation and two bug-fixes for Xen pciback Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 1/6] xen-pciback: Cleanup up pcistub_put_pci_dev Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 2/6] xen-pciback: First reset, then free Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 3/6] xen-pciback: Document when we FLR an PCI device Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 4/6] xen/pciback: Document when the 'unbind' and 'bind' functions are called Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 5/6] xen/pciback: Document the entry points for 'pcistub_put_pci_dev' Konrad Rzeszutek Wilk
2014-04-30 13:54 ` [PATCH v1 6/6] xen/pciback: Don't call xen_pcibk_config_init_dev when device de-assigned Konrad Rzeszutek Wilk
2014-04-30 14:40   ` Jan Beulich [this message]
2014-04-30 16:25 ` [PATCH v1] Documentation and two bug-fixes for Xen pciback David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53612787020000780000DDA0@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®