From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbaEAQEb (ORCPT ); Thu, 1 May 2014 12:04:31 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:58311 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbaEAQE3 (ORCPT ); Thu, 1 May 2014 12:04:29 -0400 X-Google-Original-From: Dirk Brandewie Message-ID: <53627089.8010908@intel.com> Date: Thu, 01 May 2014 09:04:25 -0700 From: Dirk Brandewie User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Stratos Karafotis , "Rafael J. Wysocki" , Viresh Kumar CC: dirk.j.brandewie@intel.com, "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH] cpufreq: intel_pstate: Remove sample parameter in intel_pstate_calc_busy References: <535FE72D.2020402@semaphore.gr> In-Reply-To: <535FE72D.2020402@semaphore.gr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/29/2014 10:53 AM, Stratos Karafotis wrote: > Since commit d37e2b7644 ("intel_pstate: remove unneeded sample buffers") > we use only one sample. So, there is no need to pass the sample > pointer to intel_pstate_calc_busy. Instead, get the pointer from > cpudata. Also, remove the unused SAMPLE_COUNT macro. > > While at it, reformat the first line in this function. > > Signed-off-by: Stratos Karafotis Acked-by: Dirk Brandewie > --- > drivers/cpufreq/intel_pstate.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 95b3958..8192ff1 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -32,8 +32,6 @@ > #include > #include > > -#define SAMPLE_COUNT 3 > - > #define BYT_RATIOS 0x66a > #define BYT_VIDS 0x66b > #define BYT_TURBO_RATIOS 0x66c > @@ -553,14 +551,13 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) > intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate); > } > > -static inline void intel_pstate_calc_busy(struct cpudata *cpu, > - struct sample *sample) > +static inline void intel_pstate_calc_busy(struct cpudata *cpu) > { > + struct sample *sample = &cpu->sample; > int32_t core_pct; > int32_t c0_pct; > > - core_pct = div_fp(int_tofp((sample->aperf)), > - int_tofp((sample->mperf))); > + core_pct = div_fp(int_tofp(sample->aperf), int_tofp(sample->mperf)); > core_pct = mul_fp(core_pct, int_tofp(100)); > FP_ROUNDUP(core_pct); > > @@ -595,7 +592,7 @@ static inline void intel_pstate_sample(struct cpudata *cpu) > cpu->sample.mperf -= cpu->prev_mperf; > cpu->sample.tsc -= cpu->prev_tsc; > > - intel_pstate_calc_busy(cpu, &cpu->sample); > + intel_pstate_calc_busy(cpu); > > cpu->prev_aperf = aperf; > cpu->prev_mperf = mperf; >