From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S937682AbdAJQif (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 11:38:35 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:21462 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932081AbdAJQie (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 11:38:34 -0500
Subject: Re: [PATCH 3/3] xen: optimize xenbus driver for multiple concurrent
 xenstore accesses
To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org
References: <20170106150544.10836-1-jgross@suse.com>
 <20170106150544.10836-4-jgross@suse.com>
 <d42f60b3-9913-5b31-4805-cb7141c17233@oracle.com>
 <9f84b972-9a76-aae2-ece6-b292bf9796cd@suse.com>
 <eadfa82a-d7b2-9f90-8046-2559c4bc93f6@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <5362b731-789b-e473-1d4d-bce4a94d7cfa@oracle.com>
Date: Tue, 10 Jan 2017 11:38:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <eadfa82a-d7b2-9f90-8046-2559c4bc93f6@oracle.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> /*
>>  * xs_response_mutex is locked as long as we are processing one
>>  * message. state.in_msg will be true as long as we are holding the
>>  * lock in process_msg().
>
> Then in_msg is the same as mutex_is_locked(&xs_response_mutex). And if
> so, do we really need it?


Nevermind this. The lock can be held by others, obviously.

-boris