From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D466A1D5160 for ; Mon, 15 Jun 2026 12:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525216; cv=none; b=fcVelLzcCwRlYTKegTVDpUGa545wUCMf96DaDcMZrAduXMe+CfG3vAUDWuLa6HLLpu8jDjvhLkXxPBzFerL3u9SD8RSxGgJBFGQBUBiEeIB5Ccf2K+7kuTeCkJpFh99nVXqG4Y9aXNbsdSwY5X7D3+ziea2gr1lqxlDdMQPpBko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525216; c=relaxed/simple; bh=hbHKXoyGu4deLtGXCbCgei2HWeyURz72UwBCmZXONcE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C/L6d/9OmMiSTLaczLO1XxHkHUnNIu7gJrmVZnBre+CC62Q+IokVbPTmUeusOgyoKan4Ive+2kYFaZrw8L78//O3KK4EnTt5XSIkJzSFj0NByeZVJCghAmqBF+VuwTivvbf4HrKp0WxwvlRhK/f0CPNraWVGqXfQYpzUZozFCCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NDdBzooF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EEDleBIT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NDdBzooF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EEDleBIT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FAoQbY3972359 for ; Mon, 15 Jun 2026 12:06:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= prn23hBPskgQBU2u3dYrNvgZ1YteGSuHw3+qudSgbvs=; b=NDdBzooFSXiEVoMk 73w5iu4t0NcqGuYQ70/k0xCKoraA1xBsZzuJ730igJuJLUy8yoiq52BqWrpAMkjj jTcz65BzMbuhi3VC28nEDUzcF7RIl1Ng2NhS/aAGgU3dG5HVCt4T9IW+iY8dCqfU os0tfEHyiaBO+rWEJxr3UhVu+jNTEKG6ROEjqQTcq8Ej0vxM4AaL8jldf5Fpbwbd fngmPsrePZASgM5RqvsngeAtoob61wwq4Nticp02coiWfEKUCzHBOtPKot1woXSJ SVBz8+hnPMB7QC5BeGCz4dn8trzq56iRciVqLXdiaHuxGIRCcZNMM/zk3F6wKzsp TM0mhw== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eteyd8hkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:06:54 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7e6b5741bbcso1134637a34.1 for ; Mon, 15 Jun 2026 05:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781525214; x=1782130014; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=prn23hBPskgQBU2u3dYrNvgZ1YteGSuHw3+qudSgbvs=; b=EEDleBITLTIirrWpPhvq8wN6MMWz2vzFAEW3BqDA0WwtdymSaSxHoy4LSLuGsg1UYk roIfleOAnmI3AkNo7wO7FZr4koZxBbXlRQ2gTL2ZhKOCQqM5kNhY/H2hiu4B2IDu0iBf 7iFkvT2wjKrEOwPbF+wvj94GINrrhUwClYCIHVwBAe8lIDbJ9aPfB79krQIc83lolEDR FhuXbUf6jfs1pQujaH1cj9cD38YdMkAEITsb9ykLvrGCARa03xuY+tZd6t7aGc7BnsSb DrlXEAlgDNmEkF4I7Bz4dDSiHZSTZnl0TpCqGVc/b+qtFXfHyaSeLIlM5lc9eojwmdes KAUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781525214; x=1782130014; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=prn23hBPskgQBU2u3dYrNvgZ1YteGSuHw3+qudSgbvs=; b=JZQkJG+7ovmh3W+omydeej4kp/Qpj53ECA686X8fg9XS7Eug7jdVabLsox/8YAxgSw qTuuYWN39dWny5cpcJxjG6KrX0uYG9RnieqQzwveOgDx/ByVzFL9VkOj9aS2q5qkCpUU hpL1jbqCXZQRCFH9c4G4qMTKzDIDfBAokKeU8VvORz6sk2d7mOXNu9Ht3LiL6yv197zY RZMxOP5yhfw/y7MYtXgxfWWDbpqfHHJ6x4JZuf41r1DqyiBKusUcQSae59lKA7JZFjuO /ZqZ5dMhMplKBajZbRihn23qel+iDWsk+bpf29EpdCkb3Ph+up6zY80rQgPYoIFmv0Gy PBFA== X-Forwarded-Encrypted: i=1; AFNElJ/ZvVy5LxJ+jT7kwzTdwxVkdlCAiFWfueP9BAPu6USGt4iQTqjPrrQ2QA99hlrGQsibPvPeB3bz0ZoR9bQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/Tudebdf3HGRdmXiY4/I4J4Kx708xF4tKUvJDLai5rW/qPKQg sDucDPbW775/dAMcvYExOHNo54acL9Zn6b6cQs1NyS9ILNr9N/qENuZshmdO/rpYIq6q1q4dWhT +5Vceqve4RW/vrlvOnopDjZNNDh/+xtgXsogYafKd7xeiNHMoCvmTDekdbP29rQ4fHOMws62SvQ E= X-Gm-Gg: Acq92OHezqfANmfi2RFdY00HGJWU9ujLi2lqTMejBgkhBxpwgx9TlZM1IxaKaOaOZ6G lvg9pTsUc8OAvKTF6oPGG8g0nDDppwqBBglXyXPvcc3fxlT2cfgSGxEfSPWEUlVt43v+HtilGZB vnwGQqhqjBJO1yi5f2AvIpQKY9eSLs0J7ZbWDe1bLyfTuZRpKGu8C/5HVkMecGoh9gK5j7LEsFa TOscqXpi71N2zOzDR+e0vc60DIbdCV79uy7mglrtTkWtNlG77jFMYn9R71FBWHSJWMw1IyOSLAC sMDVojNh/R1PMNLOX3WfXS9WuKuH7lQZ388oMVI/TTYvTZqkEjtX6IqwZGNKdMfhh4lXGy0m/6/ /OHtQKaZyuP/fY2L8/GkJMFpvIW5Y4dJsgfoAxPIEJS2PQA== X-Received: by 2002:a05:620a:280c:b0:915:4ca0:11f9 with SMTP id af79cd13be357-9161bd2835fmr1315143485a.7.1781524819717; Mon, 15 Jun 2026 05:00:19 -0700 (PDT) X-Received: by 2002:a05:620a:280c:b0:915:4ca0:11f9 with SMTP id af79cd13be357-9161bd2835fmr1315131985a.7.1781524818939; Mon, 15 Jun 2026 05:00:18 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-693794aeba0sm3578668a12.29.2026.06.15.05.00.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:00:18 -0700 (PDT) Message-ID: <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com> Date: Mon, 15 Jun 2026 14:00:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 To: Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522-qup-se-increase-ram-cnt-v1-1-71854d0b2ef0@oss.qualcomm.com> <09fb9e91-2585-4cb5-8bfb-92df304e9d6c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 3y6nQzB4yONcZah23MFNyVmwI0mBa8U3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfX8Oenajnk2cOL 86/3rJrmEE+aTXQ32DVFgRFmOhDWJoNWe/sx40ODlf0HyOl7qQdZ5pkFtlQqneKICdWwJ1GU3Vl O9hzSjL7VXPBfqcXAhcBsDcCS2o/2DI= X-Authority-Analysis: v=2.4 cv=QrJuG1yd c=1 sm=1 tr=0 ts=6a2feade cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=lRU_OWu7LYBVTaocH2QA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-ORIG-GUID: 3y6nQzB4yONcZah23MFNyVmwI0mBa8U3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfXyj9EyIGPQ9we MX9LJ3BzVQ9AWtDSZJsKKqqBgik79GdMdIELFfhQGLwsL9PQjzTrXLCji7eBCsoW1mvZS1Mc94W Shwfm3nFJvlTLH/0SmjsvcMjurgKOtY+iWzYXmwVwfDS/Z8dQUtnOTRQigklOB0vM6kUd/8YnUw Nv70EZlBvZzo1oKrF3emyLe5KG9NJxApKschgi2aMi31xPY9yrw3p8GnDljr3NGK2eQZGvpr2lS m645jJatLX2zHjBd4i6zvNdKOOe8uyOqXn+D6A2QPdb3Os9zr0DhBqnFrlHMBC2vFnIxiZKiOqL KXkM5se7jwR80/OZMPuqMMtLfFtgL3cp411UrssQec4KqATtoicy2L4EkYq1xfdv7lJiTtDXjFk wjTUwuw02qMsh1ecmXzR4h3zfv/HVDcVF2I9hPshclYA+NobvZb5rGGxPFZbvTNCr7fDlNymUAM wqsx6oj0+LhV9RM9tWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150127 On 6/15/26 7:28 AM, Viken Dadhaniya wrote: > > > On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>> entries, causing incorrect bounds checking and preventing firmware >>> loading on those targets. >>> >>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>> limit and ensure correct handling of configuration RAM regions across >>> GENI-based SE blocks. >>> >>> Signed-off-by: Viken Dadhaniya >>> --- >>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>> index cd1779b6a91a..d0810960f3da 100644 >>> --- a/drivers/soc/qcom/qcom-geni-se.c >>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>> /*Magic numbers*/ >>> #define SE_MAGIC_NUM 0x57464553 >>> >>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >> >> Is there any SoC where this could overflow the register space >> (you say "certain Qualcomm SoCs")? > > Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM > entries, so the previous limit could overflow. What I'm asking is whether the size of the RAM on any of the SoCs is less than 455 (the previous limit) Konrad