From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6F21B59A for ; Fri, 10 Jan 2025 00:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736469509; cv=none; b=CUy+p6a1HoRsDy9mc0D/2i5okA2vWvxcEdxuT97AtAjIlxbfgj6kBytcDnUqZzNE643ZkDOTqBgv/9nfiR9siqS0eX3GLF6qPY/bXsUVhbB5Y46NkosuRh9twyFidWpP3pbSVQD9GvkuUPVl7R+yUuBPT7noPK/rbvwGlnPlAbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736469509; c=relaxed/simple; bh=qWIZclo97O3t4XnMAadZI3RzDyG5vkOhisR5QJgFLj8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MqbAzy8ix+EahfsNTNJpQDaqOzih2mKGsXb+DG2zBm8DPuUd+DuokyZ5IaE3zPm4Xt/2/l4IW6ZO8isxOYOcSDFNBf3PJppTkks2tDaeG4qorQVtrIyTqh+GKeSTexqUYIbM8rQDOupKTzqBeDGjxKcw7fCh8Pi3tjY6hgLmmII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CjZB72gN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CjZB72gN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 509GX1na029425 for ; Fri, 10 Jan 2025 00:38:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kmF+DuU3JzVjgbd8y0t7kRkzSWdwvKPVstxc9QQq5H8=; b=CjZB72gNpfcFbn1B NMtx1dBmxieUB+UHEUnzOXGirMST0xzBwKWxxgG3xBILREr+mc1RPNM8glJs6TJ4 7UrMfj3kRL1NjeeBg6JBBFhTKN6ZlVkHpqPEKrTOvI9HWGCprJ4n5iE189MEVeZ5 QjCH0O/4ewSbG46ZR6neWfAZrsDoNwUUvOoYSZjatdD27+qMX4RthaCpPCgBovNd idsp2wD9VM3gLx5UMwrCbqXtGRW2q64UDUixwM4lASCDJKznwMB2P14Wyzb2qicy o7XXauBGAL8H49QJxBM93wClU5tc75LHT1br0BAoO2Dzw53TcYynueU7whoyHWDg JzaN6Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 442j2rgy3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 10 Jan 2025 00:38:26 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b6e5c3a933so12553385a.3 for ; Thu, 09 Jan 2025 16:38:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736469506; x=1737074306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kmF+DuU3JzVjgbd8y0t7kRkzSWdwvKPVstxc9QQq5H8=; b=NvNovgQRZvh8hQTkbx6IapDaOhkgXOMMGxSO5VgOR90YaE3BsUpSPGrlUeb1xKP+im Z8lGD6gNmb9clA0rvHRQp69sijBYO7sM3v0i2icuUz589hGoPR9SnFC0xcs58I3X+brm yyfV/7vxplR/wesVSxViz0vMlRQQKauywGzmTIYgRa4F+vxm09TZQ1u3OoOU6JXYuWxv IjTK/rkivUSWbNEJm8vMGZCVNiR23/KUlQLV4uvvymsGGXaqngCMDdCiKBahU7ETd6/A jnNr4mSYMkE2OA4yTtE9FEs3m3E1KkzQctQk6IeWGHZzQ0V2Gha+aYSuF0YuKmCdzJqi FFYQ== X-Forwarded-Encrypted: i=1; AJvYcCXpLy8vUECyUjYMEI18gj7si5/GTuDBdL67ZiJggPHmwt8Uiy85xIaL4pW7tuOrIBuZ5Sy+L4TNOrqXE7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxGUxpgNOBWlQhRnxnekRnnFcFFTE3ouJEKZFBLYG0Nu/xRNfoI 2D0drAeQ8gP4FU4dsAGcX6FdctoEKPt7/pft9vJ5CHyoyybyHLAALLtNQ409ws4++Jb96+WSD4X rsZnpkLGcTiZa8uhFeflWo1mzo7REqRnt5omb9aqz9FXHitIsUJfAm7R3U2YNHKQ= X-Gm-Gg: ASbGncvzISqo18QtNu2VoZQlWdWnUAthShZugWTIvdT0+tuyf5QWe6j7Nd35FmwyPPi bGjK/2ueRb1sivgBmmwZTCEjJ2wQ0nAcMqSpHIdZcNWcOIegPzraJARl2KE1NgPPNPMsi1yDZA5 31WV1QJCtlSStC/pcfYnPGM/DewMR4XP/hHwqg9liKahS8P4nWA9vK0SWFXPxHDXKMMIRCAOfEO AKekfTSmkGKvSgBAdzj9KSxMsM53S+fYUqfe3EgGzcDBdtvVf6XUXiTt2SzmKEcmxXEmqI3ppqh GTGihbhJ4fYDP0M94eAsxWV0QO4WXQhfs7M= X-Received: by 2002:a05:622a:180c:b0:467:5d7f:c684 with SMTP id d75a77b69052e-46c710e105bmr55517951cf.12.1736469506240; Thu, 09 Jan 2025 16:38:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFozTpKFg1C/Y/ohAM2r+YfB4QhoW6K8Hsfv6wtkptViZjHIU9D6x8pLZdO9xilbQsJvyLgGg== X-Received: by 2002:a05:622a:180c:b0:467:5d7f:c684 with SMTP id d75a77b69052e-46c710e105bmr55517771cf.12.1736469505858; Thu, 09 Jan 2025 16:38:25 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c95648e7sm117905366b.95.2025.01.09.16.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 16:38:24 -0800 (PST) Message-ID: <53657ae6-71a7-4800-8107-a08d47a17cb5@oss.qualcomm.com> Date: Fri, 10 Jan 2025 01:38:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 6/6] arm64: dts: qcom: sc7180: Add SoC specific compatible to soc node To: Dmitry Baryshkov , Konrad Dybcio Cc: Stephen Boyd , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Conor Dooley , Saravana Kannan , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= References: <20250108012846.3275443-1-swboyd@chromium.org> <20250108012846.3275443-7-swboyd@chromium.org> <0ab00013-0265-4336-bc30-f49492e96424@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -PBoe2oyx1TDB9hbJ-Ehck3w8LxAY8Jb X-Proofpoint-ORIG-GUID: -PBoe2oyx1TDB9hbJ-Ehck3w8LxAY8Jb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501100002 On 10.01.2025 12:45 AM, Dmitry Baryshkov wrote: > On Thu, Jan 09, 2025 at 03:10:33PM +0100, Konrad Dybcio wrote: >> On 8.01.2025 2:02 PM, Dmitry Baryshkov wrote: >>> On Tue, Jan 07, 2025 at 05:28:43PM -0800, Stephen Boyd wrote: >>>> Allow an SoC driver to probe for these devices. Add the SoC specific >>>> compatible to the soc node. Leave the original simple-bus compatible in >>>> place so that everything keeps working. >>>> >>>> Cc: Rob Herring >>>> Cc: Bjorn Andersson >>>> Cc: Konrad Dybcio >>>> Cc: >>>> Signed-off-by: Stephen Boyd >>>> --- >>>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>>> index 76fe314d2ad5..257890a193e6 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>>> @@ -782,7 +782,7 @@ soc: soc@0 { >>>> #size-cells = <2>; >>>> ranges = <0 0 0 0 0x10 0>; >>>> dma-ranges = <0 0 0 0 0x10 0>; >>>> - compatible = "simple-bus"; >>>> + compatible = "qcom,soc-sc7180", "simple-bus"; >>> >>> If the new driver requires this compatible, it will break compatibility >>> with older DT files (and it should be avoided). >> >> IIUC the intent here is to provide backwards compatibility through checking >> for sth like IS_SOCPM_MANAGED(), sorta like HAS_ACPI_COMPANION(). In that >> case, power sequencing would be done by the socpm driver, whereas if it >> doesn't hold, the resources would be toggled by the device driver > > I think that this way we end up having PM code both in the device driver > and in the socpm. Ideally in my opinion we should be able to migrate all > pm code to socpm, keeping compat with old DT files. In the end, if this > is the only change to the SoC.dtsi, then we should be able to live > without this compat change. We should be able to do that with a dynamic overlay, I suppose.. which we could drop after some time (probably a rather large amount of time) Konrad