From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754681AbdGUSlK (ORCPT ); Fri, 21 Jul 2017 14:41:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbdGUSlI (ORCPT ); Fri, 21 Jul 2017 14:41:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8DE14C053B01 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8DE14C053B01 Subject: Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants To: Lee Jones , Andy Shevchenko Cc: Jarkko Nikula , Len Brown , Mika Westerberg , linux-kernel@vger.kernel.org References: <20170701101346.13578-1-hdegoede@redhat.com> <20170701101346.13578-2-hdegoede@redhat.com> <20170717105904.iguqoroc5o74hj4f@dell> <1500297783.29303.42.camel@linux.intel.com> <20170718071725.irultqetstthnozh@dell> From: Hans de Goede Message-ID: <536760e3-c25d-740c-4705-758131d66581@redhat.com> Date: Fri, 21 Jul 2017 20:41:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170718071725.irultqetstthnozh@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 21 Jul 2017 18:41:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 18-07-17 09:17, Lee Jones wrote: > On Mon, 17 Jul 2017, Andy Shevchenko wrote: > >> On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote: >>> On Sat, 01 Jul 2017, Hans de Goede wrote: >>> >>>> Both Bay and Cherry Trail devices may be used together with a >>>> Crystal Cove >>>> PMIC. Each platform has its own variant of the PMIC, which both use >>>> the >>>> same ACPI HID, but they are not 100% compatible. >>>> >>>> This commits makes the intel_soc_pmic_core code check the _HRV of >>>> the >>>> ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp. >>>> intel_soc_pmic_config_cht_crc based on this. >>>> >>>> This fixes the Bay Trail specific ACPI OpRegion code causing >>>> problems >>>> on Cherry Trail devices. Specifically this was causing the external >>>> microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not >>>> work >>>> and the eMMC to become unreliable and throw lots of errors. >>>> >>>> Reported-and-tested-by: russianneuromancer >>>> >>> >>> Real names only please. >>> >>> What is the name of this reporter/tester? >> >> No one knows, I think. > > Then I don't think we can credit him/her for their efforts. > SubmittingPatches clearly states "no pseudonyms or anonymous > contributions". Either write to them and ask for their real name so > that they can be credited, or remove the line. russianneuromancer has been a great help with reporting and testing many Bay Trail / Cherry Trail issues. He does not want to use his real name. AFAIK the Real Name rule only applies tot he Signed-off-by tag, no other subsys-maintainers have had problems with listing him as reporter / tester using his alias. The Real Name only rule is part of "11) Sign your work — the Developer’s Certificate of Origin" of : https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Which is all about the S-o-b tag. If you despite this still want a new version with russianneuromancer's Reported-and-tested-by dropped let me know and I will send a new version. Regards, Hans