From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55980C4332F for ; Wed, 23 Nov 2022 16:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238885AbiKWQKT (ORCPT ); Wed, 23 Nov 2022 11:10:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238956AbiKWQKF (ORCPT ); Wed, 23 Nov 2022 11:10:05 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5343668C76; Wed, 23 Nov 2022 08:10:00 -0800 (PST) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 24 Nov 2022 01:10:00 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id F34592059054; Thu, 24 Nov 2022 01:09:59 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 24 Nov 2022 01:09:59 +0900 Received: from [10.212.158.163] (unknown [10.212.158.163]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 6D262A8557; Thu, 24 Nov 2022 01:09:59 +0900 (JST) Message-ID: <53680a59-ff01-bc50-ee28-ba0aaff41f3c@socionext.com> Date: Thu, 24 Nov 2022 01:09:59 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Add Socionext F_OSPI controller bindings To: Krzysztof Kozlowski , Mark Brown , Rob Herring , Krzysztof Kozlowski Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221121014800.13989-1-hayashi.kunihiko@socionext.com> <20221121014800.13989-2-hayashi.kunihiko@socionext.com> <579f9320-f114-2977-bb70-d5a26a3d2279@linaro.org> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <579f9320-f114-2977-bb70-d5a26a3d2279@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Thank you for reviewing. On 2022/11/23 18:33, Krzysztof Kozlowski wrote: > On 21/11/2022 02:47, Kunihiko Hayashi wrote: >> Add devicetree binding documentation for Socionext F_OSPI SPI flash >> controller. > > Subject: drop second, redundant "bindings". Ah, ok. I didn't notice it. I'll remove it in next. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> .../bindings/spi/socionext,f-ospi.yaml | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> new file mode 100644 >> index 000000000000..e04492c4fc84 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> @@ -0,0 +1,57 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Drop quotes from both lines. I see. I'll keep it in mind. >> + >> +title: Socionext F_OSPI controller >> + >> +description: | >> + The Socionext F_OSPI is a controller used to interface with flash >> + memories using the SPI communication interface. >> + >> +maintainers: >> + - Kunihiko Hayashi >> + >> +allOf: >> + - $ref: "spi-controller.yaml#" > > Drop quotes. Ditto. > With above: > > Reviewed-by: Krzysztof Kozlowski I'll fix the above in v3. Thank you, --- Best Regards Kunihiko Hayashi