From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D2BC4332F for ; Wed, 13 Dec 2023 18:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235501AbjLMSD3 (ORCPT ); Wed, 13 Dec 2023 13:03:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235168AbjLMSDZ (ORCPT ); Wed, 13 Dec 2023 13:03:25 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B830EE8 for ; Wed, 13 Dec 2023 10:03:31 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 475131576; Wed, 13 Dec 2023 10:04:17 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 934103F762; Wed, 13 Dec 2023 10:03:28 -0800 (PST) Message-ID: <5368ad70-1863-b19d-5334-0a5929851d4d@arm.com> Date: Wed, 13 Dec 2023 18:03:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-4-james.morse@arm.com> <2180a2a6-a61a-42ed-8a9c-5f77d10dc1ca@amd.com> From: James Morse In-Reply-To: <2180a2a6-a61a-42ed-8a9c-5f77d10dc1ca@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 09/11/2023 20:28, Moger, Babu wrote: > On 10/25/23 13:03, James Morse wrote: >> When monitoring is supported, each monitor and control group is allocated >> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to >> allocate the CLOSID. >> >> MPAM's equivalent of RMID are not an independent number, so can't be >> allocated until the CLOSID is known. An RMID allocation for one CLOSID >> may fail, whereas another may succeed depending on how many monitor >> groups a control group has. >> >> The RMID allocation needs to move to be after the CLOSID has been >> allocated. >> >> Move the RMID allocation and mondata dir creation to a helper, this >> makes a subsequent change easier to read. >> >> Tested-by: Peter Newman >> Tested-by: Shaopeng Tan >> Reviewed-by: Shaopeng Tan >> Reviewed-by: Ilpo Järvinen >> Reviewed-by: Reinette Chatre >> Signed-off-by: James Morse > > Reviewed-by: Babu Moger Thanks! James