mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jim Keniston <jkenisto@us.ibm.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2] uprobes: add comment with insn opcodes, mnemonics and why we dont support them
Date: Tue, 06 May 2014 19:01:32 +0200	[thread overview]
Message-ID: <5369156C.4000602@redhat.com> (raw)
In-Reply-To: <20140505194100.GA26916@redhat.com>

On 05/05/2014 09:41 PM, Oleg Nesterov wrote:
> On 05/05, Denys Vlasenko wrote:
>>
>> + * Opcodes we'll probably never support:
>> + * 6c-6f - ins,outs. SEGVs if used in userspace
>> + * e4-e7 - in,out imm. SEGVs if used in userspace
>> + * ec-ef - in,out acc. SEGVs if used in userspace
> 
> Well. I have no idea why they are nacked, but this is not the reason.
> 
> SEGVs are fine. Plus we have ioperm().

Noted.

Oleg, can you clear for me the following -

If the probed instruction triggers an "illegal insn" or "privileged insn"
CPU exception - are we completely fine?

Or there are some problems? how bad are they?
Slightly wrong signal stack? Wrong EFLAGs on stack?
Wrong address of failing insn?

  reply	other threads:[~2014-05-06 17:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 18:24 Denys Vlasenko
2014-05-05 18:24 ` [PATCH 2/2] uprobes: fix 1-byte opcode tables Denys Vlasenko
2014-05-05 19:41 ` [PATCH 1/2] uprobes: add comment with insn opcodes, mnemonics and why we dont support them Oleg Nesterov
2014-05-06 17:01   ` Denys Vlasenko [this message]
2014-05-06 19:26     ` Oleg Nesterov
2014-05-05 22:32 ` Jim Keniston
2014-05-06 16:11   ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5369156C.4000602@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome