From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757402AbaEISdH (ORCPT ); Fri, 9 May 2014 14:33:07 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:44010 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757378AbaEIScv (ORCPT ); Fri, 9 May 2014 14:32:51 -0400 Message-ID: <536D1F4F.4050605@linaro.org> Date: Fri, 09 May 2014 11:32:47 -0700 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bjorn Andersson , Linus Walleij CC: Russell King , linux-mmc@vger.kernel.org, Chris Ball , Ulf Hansson , "linux-kernel@vger.kernel.org" , agross@quicinc.com, linux-arm-msm Subject: Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support. References: <1398116624-31052-1-git-send-email-srinivas.kandagatla@linaro.org> <1398759492-12970-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Bjorn for testing it on msm8960 SOC. On 09/05/14 10:56, Bjorn Andersson wrote: > On Tue, Apr 29, 2014 at 1:18 AM, wrote: > [...] >> This patch series adds Qualcomm SD Card Controller support in pl180 mmci >> driver. QCom SDCC is basically a pl180, but bit more customized, some of the >> register layouts and offsets are different to the ones mentioned in pl180 >> datasheet. The plan is to totally remove the standalone SDCC driver >> drivers/mmc/host/msm_sdcc.* and start using generic mmci driver for all >> Qualcomm parts, as we get chance to test on other Qcom boards. > > Hi Srinivas, > > I think your series looks good, so I pulled it into my tree and > combined with some input from [1] I got this up and running on Sony > Xperia T (msm8960 based). > > I do get below prints in dmesg during probe, mount and some initial > accesses; but the code seems to retry the operations and things work > out nicely. Great.. Could I add your Ack on these series? > > [ 193.556540] mmcblk0: response CRC error sending r/w cmd command, > card status 0xb00 > I could not reproduce this issue with APQ8064 based IFC6410 board. I will keep testing on other boards as on when they are available. Am hoping that we could get this support for v3.16 > > PS. please send the patch enabling AMBA to Kumar as well. Sure I will send this patch to Kumar. > > [1] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commitdiff/14ea2f1dc5bb719dbfb943e2c700ac166a8c125a > > Regards, > Bjorn > thanks, srini