From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700C42EC54C for ; Thu, 4 Dec 2025 17:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764868584; cv=none; b=EJJbUYG9Gp1THrquIBeoN2nWkGLS3HOwywWEi4UO8IA4Degm4kt9NE0Ak+21c7I2yPLj1eardWjZQfeB1B4jI60HyK1cOrJ2Q0lRXFITCa6sQAI4VXVmArkTSs9vCbGI5Yz7OOUxBioNDwNywFeXXBH0dbDQZaF5Asi3SYeG4GE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764868584; c=relaxed/simple; bh=km4Dh9hQxInKzZx/6CVtSmfiE01GeOx+hzC3RItzZCI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=niht0xfKUdf/3iNfYUJTba5p9zUHq0D1viJlTcvR3N5IhAHOKHDmlnsWYGNSROBfqJ8SVAr1lxnvQFgHLbeTZDVylHWWwIqwAUDzg8L/OqlPCJSRrM7Me3v4DNBjgVw1eeZAOIn7tRdMDHR/mtHXlP/7Tsr+5iAUC58tO8ifqQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BiA+oq9p; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BiA+oq9p" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7aab7623f42so1325775b3a.2 for ; Thu, 04 Dec 2025 09:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764868579; x=1765473379; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=9as9K2dHITRu6IU+yIjl4J9GL6vgxblmI/uo3LDmiDA=; b=BiA+oq9pF4b6fLwzzpFCXc3BWr2q7jmMqSh7Y1G3BALUyBhaEmta8HkkX3qUHa4H9Y oI1s5FC66uKaW3k42HXLHdqG46JyjGZunzg2oLW/K+bPSuzy8xapjecNrnPBs36TocvU Dda+FuY7i5Ti6TinHUN95K2A27UkuBy6HBtwflNYQDyeAzzvh3PyqakZRmjx7jsUWKv/ OhCy7DGnm92V1HCzfcRyas5gImTgQkXm8t1iFW4TcZTHcJLWRzwn2u+GerHMs5QaCHsW PNr3lCrasUwnrxNv43Fr3223E3yh55PFoxRmR+hkl/1T6QS8yMqm2ham5i+fXwetIaIy CUFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764868579; x=1765473379; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9as9K2dHITRu6IU+yIjl4J9GL6vgxblmI/uo3LDmiDA=; b=feQeXDLaSe57mxjKHeFhsYlZ40rP3RE2FprO8EsaQkTcmhsA693pXy8mqc1Te0bRuZ p727LcH9AJBbUuFIXCcexw8CSTQ587aCorRQIG6P0my+/ZxPQ8+gEzGqC4j78yfAwc9T uyTyF1ZuCATR995YNw2T2q7frjPrDjBSB6afarx2St+AU/66j2HCvHqzaAN5ajYW4u4q WfjY8cuc8MwXYrc4y61ThSxXJq/M7vK+PFoW4qeNY/5BQulJ+psbM9qMMMAGpZ/WimLo gU+rDX8VtwgRdb2VkDjX7tOF7akDttW5R116MVwjIJBSKAcmjCOyf/6UkXF272DEySAS 99Hg== X-Forwarded-Encrypted: i=1; AJvYcCU2WajfEMiKU2qG0LkcrWJVD3N7CXtzhJrd/MZ1+B2vabAkA6vazqb37Fu8qtGY5VZ6g54AChXfEMB5ceY=@vger.kernel.org X-Gm-Message-State: AOJu0YzO1CF5Bxxjo5oHiEvxvmI731d+iueCk1JvB7a7xdkbr9pN72kR S8HYkz+4zINVYZxIDg9hcY9w103WlHAij676QY01s517JgWVCiYfsgUs X-Gm-Gg: ASbGncsh+ouQ0Ob9MxYvLeZKlBGO2qkOO/RIa/PYMWlyLI6fZE1IdGXIXts1T3wCOQ7 cLyui0s+PFp3EtZo2fkv/q5CwQnlRiCKSTT3ScjxDUB/00UWYjvRx8lHDhgM8iAfhB5rMisxJqS /aAnFK2XFc0dSRmn/PgvxNJnOKMxpzYOlf1IkL5twc60y6kQtOKY7Kd5dPaJoA9c3P5DmvVmZkt TeLuD10VPjKAmjNz4b5dY16HF+KPMZ5El32x1OIBVu0NTLhMaE6lWHAcPHqlcl5hnC+kcCa1y0+ C24fQsblBkW+3k+vIjERBCOIWUrN+APDcgE3ErJr4VeriyRymKJnYQB2GzEceEeX03njnly7EDG cfFnHwia2S4YI2KrK7W4wc1hxQvsdM3zh0PuYJkXQ4hbBZcKkHxsxokLYzy9HoGI6DoeIQ5oXng 68gEuNRxE32KHsKKvIX4vcIa8= X-Google-Smtp-Source: AGHT+IHAXVYFQ4q367vSeW5sz0uxGvn2ZjIkZaA1NzUcPpPtZ5Mf5JbmRDgnfViVXo5wuRHDOwdH8g== X-Received: by 2002:a05:6a20:958e:b0:350:1a0e:7fc5 with SMTP id adf61e73a8af0-363f5ed53c9mr8451647637.60.1764868578709; Thu, 04 Dec 2025 09:16:18 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf686b3bad4sm2375297a12.10.2025.12.04.09.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 09:16:18 -0800 (PST) Sender: Guenter Roeck Date: Thu, 4 Dec 2025 09:16:16 -0800 From: Guenter Roeck To: Jakub Kicinski Cc: Shuah Khan , Christian Brauner , Elizabeth Figura , Thomas Gleixner , Eric Dumazet , Kees Cook , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, wine-devel@winehq.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 00/13] selftests: Fix problems seen when building with -Werror Message-ID: <536d47f4-25b1-430a-820d-c22eb8a92c80@roeck-us.net> References: <20251204161729.2448052-1-linux@roeck-us.net> <20251204082754.66daa1c3@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204082754.66daa1c3@kernel.org> On Thu, Dec 04, 2025 at 08:27:54AM -0800, Jakub Kicinski wrote: > On Thu, 4 Dec 2025 08:17:14 -0800 Guenter Roeck wrote: > > This series fixes build errors observed when trying to build selftests > > with -Werror. > > If your intention is to make -Werror the default please stop. > Defaulting WERROR to enabled is one of the silliest things we have done > in recent past. > No, that is not the idea, and not the intention. The Google infrastructure builds the kernel, including selftests, with -Werror enabled. This triggers a number of build errors when trying to build selftests with the 6.18 kernel. That means I have three options: 1) Disable -Werror in selftest builds and accept that some real problems will slip through. Not really a good option, and not acceptable. 2) Fix the problems in the upstream kernel and backport. 3) Fix the problems downstream only. Not really a good option but I guess we'll have to do it if this series (and/or follow-up patches needed to support glibc older than 2.36) is rejected. We'll have to carry the patches downstream if 2) is rejected, but at the very least I wanted to give it a try. Guenter