From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756226AbcGGHUC (ORCPT ); Thu, 7 Jul 2016 03:20:02 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:58454 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbcGGHUA (ORCPT ); Thu, 7 Jul 2016 03:20:00 -0400 From: Arnd Bergmann To: Sanchayan Maity Cc: shawnguo@kernel.org, stefan@agner.ch, robh+dt@kernel.org, srinivas.kandagatla@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform Date: Thu, 07 Jul 2016 09:22:43 +0200 Message-ID: <5371423.yp5pHjKp9V@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:t71Jj8DanyGnJHYs/vA5QtYZVzJtqUfYQgERRJiBO0ebVuR+gx5 MP+RZ8lwrbJ6MpSZY/nAZ73NV62Gmorg7AEuw05aoXc0EoYPCktKvfZrhmucq3w4nnIlQ0O OCSnl6G+9V1h8Tww+zvNx97eDN3VojfRNuOKv6DY2XnRP+DQfcN304EPALmpsYA8xp6jX// L69XP79eMfN99qosNY8gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:rmPON91GCrg=:ddBdHc9xVq8qUpeezT8AYY mBvTKM5YYV4Fx53s9z+CaxB25qH6qNeT4Vu21puNiKmgMEFMc3RsV3WIXRpVTGHMYWkJgp1CP ZRczyRKraAmRvoRR6ag/PGcwpHhtttRNi9DJfhetgJ4p5cgJFNOr1lP7oIfV6HPGRfmcKyQUU c+oBh+xfl1UVA2yejbwMXSGusdOr5oqE02kiQVH9pmab8ofWTgdf4G8KFugxsOPNbvpM7hOqH LS2z7Sr1u+t8DR2VURQLyPM3YbY9TtKorYXvjVdd7py+SBXx8pajmRulk10NXZQK5o8DG2IP4 v79NnuRFHW9fuHERo+iuR1K+SHz228BEjG2kNbl2zp7HpKK4oVIu6qd0PhTQrOQ2SBz92CJU5 iEgSE3RFKBvY2IugdZ9i1TU8sT/hq5PPsZEJf8QqI/JUQj1ogCOSMxJQct65yh6JVJW/jghJ0 rtVvb4FJ0j65c50+jB85VNTJKUHFs6dUsZVDCFGALO5wI2OqWBdc78XfBQ9596kbKXsL1vRTs wVEUm4IamM0saGZfhIKCj08KlBbnsiNyEmoL5kU7YF9wA+ZKM3JQjNRK+9R5DrmeaO1xW3Mbs lA0fBjucnnJnxo9CGqsZ4sw0gmdIFFRk2s0OfO0U9ujSUGBgUyZhyzCTMe6cx6G9ooRsTKa1M khTrYzU/L58D9u/IiIVZO5dPyvhnpIG4SlUbfztDXpzhrtAnY/LhqDM5dKKpHz7RkLjZ9T5p2 9/DZhG3lo+rV89ii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 7, 2016 12:09:29 PM CEST Sanchayan Maity wrote: > root@colibri-vf:/sys/bus/soc/devices/soc0# cat family > Freescale Vybrid VF610 > root@colibri-vf:/sys/bus/soc/devices/soc0# cat machine > Freescale Vybrid > I only have one very high-level comment: I think that "family" is generally supposed to be the more generic one than "machine", so maybe swap the contents of the two? Can you have a look at the other users of soc_device and see how they handle it? I realize that we are already inconsistent about how we handle it, just try to make it do what the majority of the others have. Aside from that, it all looks reasonable. Arnd