From: Ruan Shiyang <ruansy.fnst@cn.fujitsu.com>
To: <miklos@szeredi.hu>, <linux-fsdevel@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fuse: clean up redundant assignment
Date: Mon, 14 Dec 2020 13:43:26 +0800 [thread overview]
Message-ID: <53733a62-c04c-48b4-af0c-e8bcaeca948b@cn.fujitsu.com> (raw)
In-Reply-To: <20201126040313.141513-1-ruansy.fnst@cn.fujitsu.com>
Hi guys,
any ideas?
--
Thanks,
Ruan Shiyang.
On 2020/11/26 下午12:03, Shiyang Ruan wrote:
> The 'err' was assigned to -ENOMEM in just few lines above, no need to be
> assigned again.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> ---
> fs/fuse/dir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index ff7dbeb16f88..f28eb54517ff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
> if (!forget)
> goto out_err;
>
> - err = -ENOMEM;
> ff = fuse_file_alloc(fm);
> if (!ff)
> goto out_put_forget_req;
>
prev parent reply other threads:[~2020-12-14 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 4:03 Shiyang Ruan
2020-12-14 5:43 ` Ruan Shiyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53733a62-c04c-48b4-af0c-e8bcaeca948b@cn.fujitsu.com \
--to=ruansy.fnst@cn.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®