mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Zak Kemble <zakkemble@gmail.com>, Doug Berger <opendmb@gmail.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] net: bcmgenet: add support for GRO software interrupt coalescing
Date: Mon, 2 Jun 2025 12:00:39 -0700	[thread overview]
Message-ID: <53748db9-2efb-4e8b-9583-5fe21fc4b993@broadcom.com> (raw)
In-Reply-To: <20250531224853.1339-1-zakkemble@gmail.com>

Hi Zak,

On 5/31/25 15:48, Zak Kemble wrote:
> Hey, these patches enable support for software IRQ coalescing and GRO
> aggregation and applies conservative defaults which can help improve
> system and network performance by reducing the number of hardware
> interrupts and improving GRO aggregation ratio.

Without this patch, seeing the following with an iperf3 server running 
at a gigabit link:

00:18:19     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
  %guest   %idle
00:18:20     all    0.53    0.00    9.36    0.00    8.56   18.98    0.00 
    0.00   62.57

and with your patches applied:

00:00:56     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
  %guest   %idle
00:00:57     all    0.00    0.00    3.29    0.00    1.01    7.34    0.00 
    0.00   88.35

so definitively helping, thanks!

Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

You will have to repost once net-next opens though:

https://patchwork.hopto.org/net-next.html

Thanks!
-- 
Florian

  parent reply	other threads:[~2025-06-02 19:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31 22:48 Zak Kemble
2025-05-31 22:48 ` [PATCH v1 1/2] net: bcmgenet: use napi_complete_done return value Zak Kemble
2025-05-31 22:48 ` [PATCH v1 2/2] net: bcmgenet: enable GRO software interrupt coalescing by default Zak Kemble
2025-06-02 19:00 ` Florian Fainelli [this message]
2025-06-09 20:35   ` [PATCH v1 0/2] net: bcmgenet: add support for GRO software interrupt coalescing Florian Fainelli
2025-06-09 21:08 Zak Kemble
2025-06-09 21:10 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53748db9-2efb-4e8b-9583-5fe21fc4b993@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=zakkemble@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®