From: Steven Whitehouse <swhiteho@redhat.com>
To: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes
Date: Fri, 16 May 2014 09:39:08 +0100 [thread overview]
Message-ID: <5375CEAC.60707@redhat.com> (raw)
In-Reply-To: <20140515185708.c1f20b1f89e4b9aeccb31a0f@skynet.be>
Hi,
I've added this patch, plus the one you sent yesterday to the GFS2 -nmw
tree. Thanks,
Steve.
On 15/05/14 17:57, Fabian Frederick wrote:
> Related function is not gfs2_set_flags but do_gfs2_set_flags
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/file.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> index 80d6725..768cbd4 100644
> --- a/fs/gfs2/file.c
> +++ b/fs/gfs2/file.c
> @@ -203,9 +203,9 @@ void gfs2_set_inode_flags(struct inode *inode)
> GFS2_DIF_INHERIT_JDATA)
>
> /**
> - * gfs2_set_flags - set flags on an inode
> - * @inode: The inode
> - * @flags: The flags to set
> + * do_gfs2_set_flags - set flags on an inode
> + * @filp: file pointer
> + * @reqflags: The flags to set
> * @mask: Indicates which flags are valid
> *
> */
> @@ -318,7 +318,7 @@ static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>
> /**
> * gfs2_size_hint - Give a hint to the size of a write request
> - * @file: The struct file
> + * @filep: The struct file
> * @offset: The file offset of the write
> * @size: The length of the write
> *
> @@ -371,7 +371,7 @@ static int gfs2_allocate_page_backing(struct page *page)
> /**
> * gfs2_page_mkwrite - Make a shared, mmap()ed, page writable
> * @vma: The virtual memory area
> - * @page: The page which is about to become writable
> + * @vmf: The virtual memory fault containing the page to become writable
> *
> * When the page becomes writable, we need to ensure that we have
> * blocks allocated on disk to back that page.
prev parent reply other threads:[~2014-05-16 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:57 Fabian Frederick
2014-05-16 8:39 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5375CEAC.60707@redhat.com \
--to=swhiteho@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome