Re: [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency

[Dmitry Osipenko <dmitry.osipenko@collabora.com>]

On 6/28/22 15:10, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
>   Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n])
>   Selected by [y]:
>   - SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]
> 
> TEGRA20_APB_DMA depends on DMADEVICES, so SOC_TEGRA_FUSE also should depends on it
> before select it.
> 
> Fixes: 19d41e5e9c68 ("soc/tegra: fuse: Add APB DMA dependency for Tegra20")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/soc/tegra/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index 5725c8ef0406..2b6ba0f798fa 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -135,6 +135,7 @@ endif
>  config SOC_TEGRA_FUSE
>  	def_bool y
>  	depends on ARCH_TEGRA
> +	depends on DMADEVICES
>  	select SOC_BUS
>  	select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
>  

Since it's a problem only for the Tegra20 config, shouldn't it be:

-  select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
+  select TEGRA20_APB_DMA if (ARCH_TEGRA_2x_SOC && DMADEVICES)

?

-- 
Best regards,
Dmitry