From: "Jan Beulich" <JBeulich@suse.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>
Cc: <david.vrabel@citrix.com>, <ian.campbell@citrix.com>,
<stefano.stabellini@eu.citrix.com>, <jeremy@goop.org>,
<matt.fleming@intel.com>, <x86@kernel.org>, <tglx@linutronix.de>,
<xen-devel@lists.xenproject.org>, <boris.ostrovsky@oracle.com>,
"Daniel Kiper" <daniel.kiper@oracle.com>, <eshelton@pobox.com>,
<mingo@redhat.com>, <mjg59@srcf.ucam.org>,
<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH v4 3/5] xen: Put EFI machinery in place
Date: Mon, 19 May 2014 14:47:47 +0100 [thread overview]
Message-ID: <537A27A30200007800013AD9@mail.emea.novell.com> (raw)
In-Reply-To: <537A0974.40302@citrix.com>
>>> On 19.05.14 at 15:39, <andrew.cooper3@citrix.com> wrote:
> On 16/05/14 21:41, Daniel Kiper wrote:
>> @@ -0,0 +1,374 @@
>> +/*
>> + * EFI support for Xen.
>> + *
>> + * Copyright (C) 1999 VA Linux Systems
>> + * Copyright (C) 1999 Walt Drummond <drummond@valinux.com>
>> + * Copyright (C) 1999-2002 Hewlett-Packard Co.
>> + * David Mosberger-Tang <davidm@hpl.hp.com>
>> + * Stephane Eranian <eranian@hpl.hp.com>
>> + * Copyright (C) 2005-2008 Intel Co.
>> + * Fenghua Yu <fenghua.yu@intel.com>
>> + * Bibo Mao <bibo.mao@intel.com>
>> + * Chandramouli Narayanan <mouli@linux.intel.com>
>> + * Huang Ying <ying.huang@intel.com>
>> + * Copyright (C) 2011 Novell Co.
>> + * Jan Beulich <JBeulich@suse.com>
>> + * Copyright (C) 2011-2012 Oracle Co.
>> + * Liang Tang <liang.tang@oracle.com>
>> + * Copyright (c) 2014 Daniel Kiper, Oracle Corporation
>> + */
>> +
>> +#include <linux/bug.h>
>> +#include <linux/efi.h>
>> +#include <linux/init.h>
>> +#include <linux/string.h>
>> +
>> +#include <xen/interface/xen.h>
>> +#include <xen/interface/platform.h>
>> +
>> +#include <asm/xen/hypercall.h>
>> +
>> +#define call (op.u.efi_runtime_call)
>
> I think not.
??? (Read: What's wrong with putting this shortcut in place?)
>> +#define DECLARE_CALL(what) \
>> + struct xen_platform_op op; \
>> + op.cmd = XENPF_efi_runtime_call; \
>> + call.function = XEN_EFI_##what; \
>> + call.misc = 0
>
> Macros like this which explicitly create local variable with implicit
> names are evil when reading code.
>
> If you want to do initialisation like this, then at least do something like:
>
> #define INIT_EFI_CALL(what) \
> { .cmd = XENPF_efi_runtime_call, \
> .u.efi_runtime_call.function = XEN_EFI_##what, \
> .u.efi_runtime_call.misc = 0 }
>
> And use it as:
>
> struct xen_platform_op op = INIT_EFI_CALL(foo);
That's minimal redundancy as a goal versus (to you, but not to me)
legibility.
Jan
next prev parent reply other threads:[~2014-05-19 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 20:41 [PATCH v4 0/5] xen: Add EFI support Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 1/5] efi: Introduce EFI_DIRECT flag Daniel Kiper
2014-05-19 13:30 ` Jan Beulich
2014-05-19 20:46 ` Daniel Kiper
2014-05-20 6:16 ` Jan Beulich
2014-05-19 15:58 ` David Vrabel
2014-05-19 21:02 ` Daniel Kiper
2014-05-22 7:26 ` Matt Fleming
2014-05-16 20:41 ` [PATCH v4 2/5] xen: Define EFI related stuff Daniel Kiper
2014-05-19 16:00 ` David Vrabel
2014-05-16 20:41 ` [PATCH v4 3/5] xen: Put EFI machinery in place Daniel Kiper
2014-05-19 13:39 ` [Xen-devel] " Andrew Cooper
2014-05-19 13:47 ` Jan Beulich [this message]
2014-05-19 13:43 ` Jan Beulich
2014-05-20 9:47 ` David Vrabel
2014-05-20 11:29 ` Daniel Kiper
2014-05-20 11:58 ` Jan Beulich
2014-05-20 12:10 ` David Vrabel
2014-05-16 20:41 ` [PATCH v4 4/5] arch/x86: Replace plain strings with constants Daniel Kiper
2014-05-22 7:56 ` Matt Fleming
2014-05-16 20:41 ` [PATCH v4 5/5] arch/x86: Remove redundant set_bit() call Daniel Kiper
2014-05-22 7:59 ` Matt Fleming
2014-05-19 15:53 ` [PATCH v4 0/5] xen: Add EFI support David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A27A30200007800013AD9@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=eshelton@pobox.com \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®