Re: [PATCH -next 3/8] iommufd/selftest: Make dirty_ops static

[Yi Liu <yi.l.liu@intel.com>]

On 2024/8/19 20:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
> 
> drivers/iommu/iommufd/selftest.c:277:30: warning:
> 	symbol 'dirty_ops' was not declared. Should it be static?
> 
> This symbol is not used outside of selftest.c, so marks it static.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>   drivers/iommu/iommufd/selftest.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Yi Liu <yi.l.liu@intel.com>

> diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c
> index 04293b20e20c..7464c24764cd 100644
> --- a/drivers/iommu/iommufd/selftest.c
> +++ b/drivers/iommu/iommufd/selftest.c
> @@ -274,7 +274,7 @@ static int mock_domain_read_and_clear_dirty(struct iommu_domain *domain,
>   	return 0;
>   }
>   
> -const struct iommu_dirty_ops dirty_ops = {
> +static const struct iommu_dirty_ops dirty_ops = {
>   	.set_dirty_tracking = mock_domain_set_dirty_tracking,
>   	.read_and_clear_dirty = mock_domain_read_and_clear_dirty,
>   };

-- 
Regards,
Yi Liu