From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751313AbcHAFH4 (ORCPT ); Mon, 1 Aug 2016 01:07:56 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54028 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcHAFHs (ORCPT ); Mon, 1 Aug 2016 01:07:48 -0400 Subject: Re: [PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services() To: Andy Lutomirski , x86@kernel.org References: Cc: Mario Limonciello , Matthew Garrett , Borislav Petkov , Matt Fleming , linux-kernel@vger.kernel.org From: "H. Peter Anvin" Message-ID: <5389d894-64c0-5f5f-6ed6-e08077f1dc8e@zytor.com> Date: Sun, 31 Jul 2016 22:07:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/26/16 15:55, Andy Lutomirski wrote: > + /* > + * Nasty quirk: if all sub-1MB memory is used for boot > + * services, we can get here without having allocated the > + * real mode trampoline. It's too late to hand boot services > + * memory back to the memblock allocator, so instead > + * try to reclaim a single page if needed. > + * This comment makes no sense. Nowhere is there a dependency on a single page, and this refers to allocation, not reclaim... -hpa