From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Marek Vasut <marex@denx.de>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Stefan Wahren <stefan.wahren@i2se.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Markus Niebel <Markus.Niebel@tq-group.com>,
Heiko Stuebner <heiko@sntech.de>,
Bjorn Andersson <andersson@kernel.org>,
Chris Morgan <macromorgan@hotmail.com>,
Jagan Teki <jagan@edgeble.ai>,
Conor Dooley <conor.dooley@microchip.com>,
Li Yang <leoyang.li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM
Date: Wed, 10 May 2023 15:01:42 +0200 [thread overview]
Message-ID: <538a009b-d5b5-da72-f775-9ec89b34afda@linaro.org> (raw)
In-Reply-To: <20230510112347.3766247-3-himanshu.bhavani@siliconsignals.io>
On 10/05/2023 13:23, Himanshu Bhavani wrote:
> Add entries to the list of imx8mm boards denoting
> the Emtop SOM from Emtop.
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..06eb2c790f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -884,6 +884,7 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
> - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
> + - emtop,imx8mm-emtop # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM
No real improvements. Still not change in compatible - neither naming
nor additional compatible.
Instead of adding some random changes, please describe in commit msg
what is this exactly and then use compatibles matching it.
You already got two times the same comment that board called "emtop" so
the same as vendor "emtop" looks wrong. You never responded to these
comments. Don't ignore feedbacks, but either respond or implement them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-10 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 11:23 [PATCH v4 0/3] arm64: dts: Add initial support for Emtop SOM IMX8MM Himanshu Bhavani
2023-05-10 11:23 ` [PATCH v4 1/3] arm64: dts: Add device tree for the " Himanshu Bhavani
2023-05-10 12:51 ` Marco Felsch
2023-05-10 12:59 ` Krzysztof Kozlowski
2023-05-10 11:23 ` [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM Himanshu Bhavani
2023-05-10 13:01 ` Krzysztof Kozlowski [this message]
2023-05-10 11:23 ` [PATCH v4 3/3] dt-bindings: vendor-prefixes: Add Emtop Himanshu Bhavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538a009b-d5b5-da72-f775-9ec89b34afda@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Markus.Niebel@tq-group.com \
--cc=andersson@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=heiko@sntech.de \
--cc=himanshu.bhavani@siliconsignals.io \
--cc=jagan@edgeble.ai \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®