mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Maurizio Casciano <mauriziocasciano7@gmail.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	Jaroslav Kysela <perex@perex.cz>, "Takashi Iwai" <tiwai@suse.com>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Date: Wed, 26 Aug 2026 16:11:34 +0200	[thread overview]
Message-ID: <538bbc27-8796-416e-a10c-3033d6168bcd@intel.com> (raw)
In-Reply-To: <20260826132334.3344395-1-mauriziocasciano7@gmail.com>

On 8/26/2026 3:23 PM, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91F/L uses a Cherry Trail SSP2 connection to
> an RT5677 codec, with board-specific amplifier, headphone and headset
> detector wiring.  Add the machine driver, the SST machine-table match,
> and the SOF topology filename used by the corresponding external SOF
> topology.
> 
> The companion platform/x86 series supplies the TS3A227E device and codec
> GPIO lookup entries.  The sof-cht-rt5677.tplg topology is maintained in
> the SOF project and must be merged and distributed separately.
> 
> With the matching topology installed, the Yoga Book reaches the SOF
> card-registration and stream setup path.  End-to-end playback and
> capture acceptance is not complete, so this is posted as an RFC.
> 
> Maurizio Casciano (3):
>    ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver
>    ASoC: Intel: cht: Match the Yoga Book RT5677 machine
>    ASoC: Intel: cht: Add Yoga Book SOF topology filename
Hello,

Unless I'm missing something, this looks like a resend of a patchset 
from earlier this year [1]. Previous owner of the subject, Yauhen 
Kharuzhy, is not even CC'ed here. I do not see any of the review points 
addressed here, moreover, I see a regression when compared to v3 from June.

Hiding behind RFC (not v4) is a weird move when viewed in context of 
CHT. The configuration is mature, CHT is over 12 years old. With basic 
playback/capture not enabled, does the review make sense?


[1]: 
https://lore.kernel.org/linux-sound/20260611-asoc-yogabook-v2-v3-0-3128447b67b6@gmail.com/

Kind regards,
Czarek

  parent reply	other threads:[~2026-08-26 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 13:23 Maurizio Casciano
2026-08-26 13:23 ` [RFC PATCH 1/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver Maurizio Casciano
2026-08-26 13:23 ` [RFC PATCH 2/3] ASoC: Intel: cht: Match the Yoga Book RT5677 machine Maurizio Casciano
2026-08-26 13:23 ` [RFC PATCH 3/3] ASoC: Intel: cht: Add Yoga Book SOF topology filename Maurizio Casciano
2026-08-26 14:11 ` Cezary Rojewski [this message]
2026-08-27  7:26   ` [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support Maurizio Casciano
2026-08-27 18:13   ` Maurizio Casciano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538bbc27-8796-416e-a10c-3033d6168bcd@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mauriziocasciano7@gmail.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®