Re: [PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

[Ian Abbott <abbotti@mev.co.uk>]

On 2014-06-04 03:32, Chase Southwood wrote:
> This patchset introduces a new private data struct for this driver, adds
> all of the code required to support Change-of-State interrupts for the
> digital input subdevice, and finally fixes
> apci1564_interrupt() to service this type of interrupt correctly.
>
> CHANGES FROM v1:
> *leave the send_sig() calls in for now, until the proper replacement can
> be implemented.
> *removed unused static globals, removed the remaining one into the private
> data struct.
> *private data struct moved into addi_apci_1564.c.
> *patches 4/6 and 5/6 from v1 have been merged into patch 4/5 here.
> *(*cancel) for the interrupt subdevice has been reduced to just disable DI
> interrupts rather than using the board's reset function.
> *support for all interrupts issued by the board has been kept in
> apci1564_interrupt(), rather than stripping everything out except for DI
> interrupt support.  However, DI interrupt support has still been fixed.
>
> Chase Southwood (5):
>    staging: comedi: addi_apci_1564: remove use of
>      devpriv->b_OutputMemoryStatus
>    staging: comedi: addi_apci_1564: remove unused static variables
>    staging: comedi: addi_apci_1564: introduce apci1564_private struct
>    staging: comedi: addi_apci_1564: add Change-of-State interrupt
>      subdevice and required functions
>    staging: comedi: addi_apci_1564: move apci1564_interrupt() into
>      addi_apci_1564.c
>
>   .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 304 +++------------
>   drivers/staging/comedi/drivers/addi_apci_1564.c    | 433 +++++++++++++++++++--
>   2 files changed, 454 insertions(+), 283 deletions(-)
>

Looks good!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-