From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FFD01990D9; Mon, 27 Oct 2025 14:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761576105; cv=none; b=OaAi8/ykXy51CKpnRRKviA2QVHbXncYxc9p8T6cWGmUX4CVPCy6ScbQfTDTa2ISx1M8pKlbUrJ1Jrxn+PqKVgBr7LBeYJCSppL1KrLhAjeqgBTlESLLWkWcce2Dvof9YnvYljDpWF+YjX0l6o/s412ADk6Q1+4ZaskGnmAn1OWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761576105; c=relaxed/simple; bh=vhHN2CWlz68ehyr1Y2hDojwu9+Vue88/Z0ZxYv7WECM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OgZ7moBIetzX0+utJy7wexxg8b8lQad9QDrf3K5vRoIV2+rHj9VHlWAQ6aB1VaTydHOkyJ8w8TgdKzNoDSQ3+dddp3j/HS/yrYOc0tFosku/Zzn5+D+4vpNYrBCccyYQprHk0wU2Eqe2KHJkH8xrOC3aBIeYcAAlK4rLSTHkEPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=kxwSkzWF; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kxwSkzWF" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sgneSpTtmkYD7aVSON0HmkCfsNXMfkSDiuyU+kka0Ww=; b=kxwSkzWFmWtZhEHJ0UgnvuvjhV qPy/NTHigiOoD3XebU6/1WMXTxbJdsxzbDmnVDqT58uivysQ+lMtLy1D87iPDdyZGBTbBE9FLcIfl CVy+snMTfmeO2KGPVz+ODvUC244Qmmz+YBV2R9QkfbEbRwmFBFF8HpXyq9/IvtQlza/E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vDOPU-00CCd4-G7; Mon, 27 Oct 2025 15:41:24 +0100 Date: Mon, 27 Oct 2025 15:41:24 +0100 From: Andrew Lunn To: Francesco Dolcini Cc: Russell King , Emanuele Ghidoli , Heiner Kallweit , Emanuele Ghidoli , Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1] net: phy: dp83867: Disable EEE support as not implemented Message-ID: <539795a1-2a69-4fcb-88e7-ca4e3b13ad7c@lunn.ch> References: <20251023144857.529566-1-ghidoliemanuele@gmail.com> <664ef58b-d7e6-4f08-b88f-e7c2cf08c83c@gmail.com> <20251027143522.GA57409@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251027143522.GA57409@francesco-nb> > I was talking together with Emanuele on this topic and we are confused > on how to proceed. > > >From the various comments and tests in this thread, to me the actual > code change is correct, the dp83867 does not support EEE and we have to > explicitly disable it in the dp83867 driver. > > As of now we do not have a clear shared understanding on what is going > on in the stmmac driver. And the commit message is not correct on this > regard. > > This patch is already merged [1] in netdev tree, should we send a series > reverting this commit and another commit with just the same change and a > different commit message? No, if its merged, its merged. What should come out of this is a learning, please be precise with commit messages, more detail rather than less, and provide as much supporting evidence as you can for any claims you make. > In parallel, unrelated to the dp83867 topic, Emanuele is trying to help > figuring out why the actual behavior of the stmmac changed after Russell > refactoring. And it's clear that this change in behavior is not expected. Great. Andrew