From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E692C33CAD for ; Mon, 13 Jan 2020 14:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A895207FD for ; Mon, 13 Jan 2020 14:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728774AbgAMOsO (ORCPT ); Mon, 13 Jan 2020 09:48:14 -0500 Received: from mga06.intel.com ([134.134.136.31]:9992 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbgAMOsO (ORCPT ); Mon, 13 Jan 2020 09:48:14 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 06:48:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,429,1571727600"; d="scan'208";a="217425109" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.167]) ([10.237.72.167]) by orsmga008.jf.intel.com with ESMTP; 13 Jan 2020 06:48:11 -0800 Subject: Re: [PATCH] perf tools: intel-pt: fix endless record after being terminated To: Wei Li , acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, huawei.libin@huawei.com References: <20200102074211.19901-1-liwei391@huawei.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <539e4aca-3bae-6586-fefd-8be49308b5d7@intel.com> Date: Mon, 13 Jan 2020 16:47:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200102074211.19901-1-liwei391@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/01/20 9:42 am, Wei Li wrote: > In __cmd_record(), when receiving SIGINT(ctrl + c), a done flag will > be set and the event list will be disabled by evlist__disable() once. > > While in auxtrace_record.read_finish(), the related events will be > enabled again, if they are continuous, the recording seems to be endless. > > If the intel_pt event is disabled, we don't enable it again here. > > Before the patch: > huawei@huawei-2288H-V5:~/linux-5.5-rc4/tools/perf$ ./perf record -e \ > intel_pt//u -p 46803 > ^C^C^C^C^C^C > > After the patch: > huawei@huawei-2288H-V5:~/linux-5.5-rc4/tools/perf$ ./perf record -e \ > intel_pt//u -p 48591 > ^C[ perf record: Woken up 0 times to write data ] > Warning: > AUX data lost 504 times out of 4816! > > [ perf record: Captured and wrote 2024.405 MB perf.data ] > > Signed-off-by: Wei Li All ->read_finish() implementations seem the same, so can we make a common helper auxtrace_read_finish() and set all .read_finish = to that. > --- > tools/perf/arch/x86/util/intel-pt.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c > index 20df442fdf36..1e96afcd8646 100644 > --- a/tools/perf/arch/x86/util/intel-pt.c > +++ b/tools/perf/arch/x86/util/intel-pt.c > @@ -1173,9 +1173,13 @@ static int intel_pt_read_finish(struct auxtrace_record *itr, int idx) > struct evsel *evsel; > > evlist__for_each_entry(ptr->evlist, evsel) { > - if (evsel->core.attr.type == ptr->intel_pt_pmu->type) > - return perf_evlist__enable_event_idx(ptr->evlist, evsel, > - idx); > + if (evsel->core.attr.type == ptr->intel_pt_pmu->type) { > + if (evsel->disabled) > + return 0; > + else > + return perf_evlist__enable_event_idx( > + ptr->evlist, evsel, idx); > + } > } > return -EINVAL; > } >