From: "Jan Beulich" <JBeulich@suse.com>
To: "Daniel Kiper" <daniel.kiper@oracle.com>
Cc: <andrew.cooper3@citrix.com>, <david.vrabel@citrix.com>,
<ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>,
<jeremy@goop.org>, <matt.fleming@intel.com>, <x86@kernel.org>,
<tglx@linutronix.de>, <xen-devel@lists.xenproject.org>,
<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>,
<eshelton@pobox.com>, <mingo@redhat.com>, <mjg59@srcf.ucam.org>,
<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hpa@zytor.com>
Subject: Re: [PATCH v6 1/9] efi: Use early_mem*() instead of early_io*()
Date: Mon, 23 Jun 2014 08:19:00 +0100 [thread overview]
Message-ID: <53A7F104020000780001C4BE@mail.emea.novell.com> (raw)
In-Reply-To: <1403299768-9955-2-git-send-email-daniel.kiper@oracle.com>
>>> On 20.06.14 at 23:29, <daniel.kiper@oracle.com> wrote:
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -298,7 +298,7 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
> if (table64 >> 32) {
> pr_cont("\n");
> pr_err("Table located above 4GB, disabling EFI.\n");
> - early_iounmap(config_tables,
> + early_memunmap(config_tables,
> efi.systab->nr_tables * sz);
> return -EINVAL;
> }
> @@ -314,7 +314,7 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
> tablep += sz;
> }
> pr_cont("\n");
> - early_iounmap(config_tables, efi.systab->nr_tables * sz);
> + early_memunmap(config_tables, efi.systab->nr_tables * sz);
>
> set_bit(EFI_CONFIG_TABLES, &efi.flags);
>
If these two changes are really deemed necessary (there's the
implied assumption currently in place that early_iounmap() can
undo early_memremap() mappings), then ia64 will need a
definition added for early_memunmap() or its build will break.
Jan
next prev parent reply other threads:[~2014-06-23 7:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 21:29 [PATCH v6 0/9] xen: Add EFI support Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 1/9] efi: Use early_mem*() instead of early_io*() Daniel Kiper
2014-06-23 7:19 ` Jan Beulich [this message]
2014-06-23 13:54 ` Daniel Kiper
2014-06-24 17:56 ` Luck, Tony
2014-06-20 21:29 ` [PATCH v6 2/9] arch/x86: Do not access EFI memory map if it is not available Daniel Kiper
2014-06-23 9:53 ` David Vrabel
2014-06-23 11:00 ` Jan Beulich
2014-06-23 14:13 ` Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 3/9] efi: Introduce EFI_PARAVIRT flag Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 4/9] arch/x86: Remove redundant set_bit(EFI_SYSTEM_TABLES) call Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 5/9] arch/x86: Remove redundant set_bit(EFI_MEMMAP) call Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 6/9] xen: Define EFI related stuff Daniel Kiper
2014-06-23 9:50 ` David Vrabel
2014-06-20 21:29 ` [PATCH v6 7/9] xen: Put EFI machinery in place Daniel Kiper
2014-06-21 14:53 ` Stefano Stabellini
2014-06-23 9:57 ` [Xen-devel] " David Vrabel
2014-06-23 13:57 ` Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 8/9] arch/x86: Replace plain strings with constants Daniel Kiper
2014-06-20 21:29 ` [PATCH v6 9/9] arch/x86: Remove efi_set_rtc_mmss() Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A7F104020000780001C4BE@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=eshelton@pobox.com \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®